Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove errant .css('height') && .css('width') checks #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove errant .css('height') && .css('width') checks #223

wants to merge 2 commits into from

Commits on Sep 27, 2015

  1. Remove errant .css('height') && .css('width') checks 

    iFrames have a default width (300px) and height (150px):
http://stackoverflow.com/questions/5871668/default-width-height-of-an-iframe
Becuase of this, .css('height') && .css('width') will
return these default values, meaning that our video ends up with an
aspect ratio of 2:1 rather than 16:9
    Jason Darwin committed Sep 27, 2015
    Configuration menu
    Copy the full SHA
    a897c6b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2015

  1. Ensure videos with height/width in the style attribute are made respo… 

    …nsive
    Jason Darwin committed Sep 29, 2015
    Configuration menu
    Copy the full SHA
    4633291 View commit details
    Browse the repository at this point in the history