fix: eliminate the usage of NIT

datnguye · Mar 30, 2024 · 13c5781 · 13c5781
1 parent 0aa2b65
commit 13c5781
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/dbterd/adapters/base.py b/dbterd/adapters/base.py
@@ -1,6 +1,5 @@
 import os
 from pathlib import Path
-from types import NotImplementedType
 from typing import List, Tuple
 
 import click
@@ -239,9 +238,6 @@ def __run_by_strategy(
         if not kwargs.get("api"):
             self.__save_result(path=kwargs.get("output"), data=result)
 
-        if type(result) == NotImplementedType:
-            return result
-
         return result[1]
 
     def __run_metadata_by_strategy(self, **kwargs) -> Tuple[List[Table], List[Ref]]:
@@ -254,7 +250,4 @@ def __run_metadata_by_strategy(self, **kwargs) -> Tuple[List[Table], List[Ref]]:
         if not kwargs.get("api"):
             self.__save_result(path=kwargs.get("output"), data=result)
 
-        if type(result) == NotImplementedType:
-            return result
-
         return result[1]
diff --git a/dbterd/adapters/targets/default.py b/dbterd/adapters/targets/default.py
@@ -2,6 +2,6 @@ def default(**kwargs):
     """Fallback option if the target is not supported yet
 
     Returns:
-        NotImplemented: NotImplemented
+        Tuple[None, None]
     """
-    return NotImplemented
+    return (None, None)
diff --git a/tests/unit/adapters/test_base.py b/tests/unit/adapters/test_base.py
@@ -1,5 +1,4 @@
 from pathlib import Path
-from types import NotImplementedType
 from unittest import mock
 
 import click
@@ -36,7 +35,7 @@ def test___run_metadata_by_strategy_with_not_implemented_algo(
         result = Executor(
             ctx=click.Context(command=click.BaseCommand("dummy"))
         )._Executor__run_metadata_by_strategy(target="dbml", algo="notfound")
-        assert type(result) == NotImplementedType
+        assert result is None
         mock_query_erd_data.assert_called_once()
         mock_save_result.assert_called_once()