Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace psycopg2-binary with pg8000 and black with ruff #25

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Replace psycopg2-binary with pg8000 and black with ruff #25

merged 2 commits into from
Oct 14, 2024

Conversation

Gerrrr
Copy link
Contributor

@Gerrrr Gerrrr commented Oct 10, 2024 •
edited
Loading

  • psycopg2 is licensed under LGPL that's not compatible with ASF -https://www.apache.org/legal/resolved.html#category-x
  • black depends on pathspec that is licensed under MPL 2.0. Even though MPL 2.0 can maybe included in an ASF project, I'd prefer to simplify the discussion and just replace black with ruff that is licensed as Apache 2.0, does not have any dependencies, and is already used by other Apache projects.

@Gerrrr
Replace psycopg2-binary with pg8000
8b4b95b 
psycopg2 is licensed under LGPL that's not compatible with ASF -
https://www.apache.org/legal/resolved.html#category-x
@Gerrrr
Replace black with ruff
aca962d 
black depends on pathspec that is licensed under MPL 2.0. Even though
MPL 2.0 can _maybe_ be included in an ASF project, I'd
prefer to simplify the discussion and just replace black with ruff that
is licensed as Apache 2.0, does not have any dependencies, and is
already used by other Apache projects.
@Gerrrr Gerrrr changed the title Replace psycopg2-binary with pg8000 Replace psycopg2-binary with pg8000 and black with ruff Oct 12, 2024
smccarthy788
smccarthy788 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@smccarthy788 smccarthy788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive how compatible these changes were.

@smccarthy788 smccarthy788 merged commit bc748fc into datastax-labs:master Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikingo henrikingo henrikingo approved these changes

@smccarthy788 smccarthy788 smccarthy788 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gerrrr @henrikingo @smccarthy788