Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced cleaning and validating for GTFS #256

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

CBROWN-ONS
Copy link
Collaborator

Description

This issue merges some of the features from #195
This PR will allow for a pipelined approach while cleaning and validating a GTFS.

Motivation and Context

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test configuration details:

  • OS: Windows 10
  • Python version: 3.9.13
  • Java version: N/A
  • Python management system: MiniConda

Advice for reviewer

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (cef299b) to head (cdc5b6a).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #256      +/-   ##
==========================================
+ Coverage   98.13%   98.81%   +0.67%     
==========================================
  Files          21       21              
  Lines        1983     2018      +35     
==========================================
+ Hits         1946     1994      +48     
+ Misses         37       24      -13     
Flag Coverage Δ
unittests 98.81% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants