Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #7

Merged
merged 16 commits into from
Jul 10, 2023
Merged

New features #7

merged 16 commits into from
Jul 10, 2023

Conversation

ColinDaglish
Copy link
Collaborator

@ColinDaglish ColinDaglish commented Jun 28, 2023

Amended config with new filepath
created folder for raw data
amended pipeline ordering to work with dummy data
added spelling fixer
added word cloud feature
added unit tests

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 64.07% and project coverage change: +21.39 🎉

Comparison is base (348afbf) 43.18% compared to head (9a2fb6a) 64.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   43.18%   64.57%   +21.39%     
===========================================
  Files           4        5        +1     
  Lines          88      223      +135     
===========================================
+ Hits           38      144      +106     
- Misses         50       79       +29     
Impacted Files Coverage Δ
src/processing/visualisation.py 0.00% <0.00%> (ø)
src/run_pipeline.py 0.00% <0.00%> (ø)
tests/processing/test_preprocessing.py 80.34% <78.09%> (-19.66%) ⬇️
src/processing/preprocessing.py 74.62% <78.12%> (+26.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ColinDaglish ColinDaglish changed the title amending pipeline to work with test data New features Jul 6, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. How would you typically review and update this as new words come to light?

@brenng1
Copy link
Contributor

brenng1 commented Jul 10, 2023

Some really great changes in here Colin, I'm still playing catch up on fully appreciating things, but looks great so far.

@brenng1 brenng1 closed this Jul 10, 2023
@ColinDaglish ColinDaglish reopened this Jul 10, 2023
@brenng1 brenng1 merged commit 3441d1f into main Jul 10, 2023
4 checks passed
@brenng1 brenng1 deleted the implement_pipeline_on_test_data branch July 10, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants