Skip to content

Commit

Permalink
Merge pull request #64 from IndexSeek/main
Browse files Browse the repository at this point in the history
Minor spelling - added codespell, pre-commit isort issue, poetry to setuptools
  • Loading branch information
murilo-cunha authored May 8, 2023
2 parents 3978126 + 3390f4b commit d6884d2
Show file tree
Hide file tree
Showing 6 changed files with 616 additions and 180 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
needs: get-new-tag
env:
POETRY_VERSION: 1.1.7
POETRY_VERSION: 1.2.2
steps:
- uses: actions/checkout@v2
- name: Set up Python 3.8
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
runs-on: ubuntu-latest
needs: [get-new-tag, publish]
env:
POETRY_VERSION: 1.1.7
POETRY_VERSION: 1.2.2
steps:
- uses: actions/checkout@v2
with:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,20 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
pip install poetry==1.1.7
poetry config virtualenvs.create false
pip install poetry==1.2.2
poetry install --no-interaction --no-ansi
- name: QA with flake8, black, isort and mypy
run: |
pre-commit run --all-files
poetry run pre-commit run --all-files
- name: Configure git user for git unit tests
run: |
git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
- name: Unit tests
run: |
pytest -vv
poetry run pytest -vv
- name: Coverage report
run: |
pytest --cov=./ --cov-report=xml
poetry run pytest --cov=./ --cov-report=xml
- name: Upload coverage
uses: codecov/codecov-action@v1
6 changes: 5 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repos:
- id: black
files: (databooks/|tests/)
- repo: https://github.com/pycqa/isort
rev: 5.10.1
rev: 5.11.5
hooks:
- id: isort
files: (databooks/|tests/)
Expand All @@ -37,6 +37,10 @@ repos:
- GitPython==3.1.26
- typing-extensions==4.0.1
- tomli==2.0.1
- repo: https://github.com/codespell-project/codespell
rev: v2.2.4
hooks:
- id: codespell
- repo: local
hooks:
- id: update-docs
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ pytest --cov-report html --cov=databooks tests/
## Publishing

Publishing is automatically done via [Github Actions](https://github.com/features/actions)
to PiPy. After published, a new tag and release are created. A new docs version is also
to PyPI. After published, a new tag and release are created. A new docs version is also
published if all previous steps are successful.

## Contributors 👨‍💻👩‍💻
Expand Down
2 changes: 1 addition & 1 deletion databooks/git_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def get_nb_diffs(
"""
Get the noteebook(s) git diff(s).
By default, diffs are compared with the current working direcotory. That is, staged
By default, diffs are compared with the current working directory. That is, staged
files will still show up in the diffs. Only return the diffs for notebook files.
"""
if verbose:
Expand Down
Loading

0 comments on commit d6884d2

Please sign in to comment.