Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Fix PropertySet's unique_indexes method. #282

Closed
wants to merge 1 commit into from

Conversation

J-F-Liu
Copy link

@J-F-Liu J-F-Liu commented Apr 13, 2015

Related Issue: #281

@J-F-Liu
Copy link
Author

J-F-Liu commented Apr 13, 2015

rake run result:

Finished in 58.35322 seconds

12822 examples, 0 failures, 3505 pending

@tpitale
Copy link
Member

tpitale commented Feb 8, 2016

@J-F-Liu Do you have a failing test case that this fixes?

@J-F-Liu
Copy link
Author

J-F-Liu commented Feb 10, 2016

@tpitale Sorry, I didn't write a test case for this.

@tpitale
Copy link
Member

tpitale commented Feb 14, 2016

@J-F-Liu Looks like you had something from #281's original report. If you could add something I'll merge this.

@tpitale tpitale added this to the 1.3.0 milestone Feb 14, 2016
@J-F-Liu
Copy link
Author

J-F-Liu commented Feb 15, 2016

I write a test case in rspec, but the InMemoryAdapter doesn't have the ability to check uniqueness, so the expected error is not raised.

@tpitale
Copy link
Member

tpitale commented May 24, 2016

I don't think we want to include this change to the API for property unique indexes to support a new case at this time. We're drowning maintenance and adding new cases will only make this worse.

@tpitale tpitale closed this May 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants