Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SCSS #36

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Migrate to SCSS #36

wants to merge 17 commits into from

Conversation

Leland
Copy link
Contributor

@Leland Leland commented Dec 27, 2023

Ultimately, this PR is about cleaning up some very old assets, moving to a modular SCSS approach, and thus clearing the way for far easier styling without needing to deeply override Bootstrap.

This also comes with other benefits, like not shipping unused Bootstrap features, and sourcemaps:

image

Major

  • Removes jQuery UI entirely, as it appears unused
  • Converts custom styles into SCSS, and moves Bootstrap and the Bootswatch theme to the same, fixing visual inconsistencies as a result
  • Upgrades from Bootstrap v3.3.1 to v3.4.1, the final 3.x release
  • Moves assets (CSS, JS, audio, images) to the directory structure noted on the Jekyll docs:
    .
      ├── assets
      │   ├── css
      │   ├── images
      │   └── js
      │   └── audio
      ...
      

Minor

  • Introduces a .editorconfig file
  • Reformats all JS, CSS, and HTML that is not from a vendor using the default Prettier config
  • Moves vendored JS into a dedicated folder
  • Moves CDN-based files into vendorized assets
  • Remove LICENSE and README.md from production site
  • Remove unused Bootstrap partials from full output

WIP, more coming.

This is a file that has become a de facto standard for IDEs
to automatically know a project's preferred formatting
vendor folders makes it much clearer what comes from contributors
and what is just tracked from external sources
@Leland Leland force-pushed the style-tweaks branch 3 times, most recently from ebb7a17 to ec4c335 Compare December 27, 2023 05:59
@Leland
Copy link
Contributor Author

Leland commented Dec 27, 2023

The scope of this grew a bit.

I'll split out the Bootstrap SCSS work to its own PR.

@Leland Leland changed the title Clean up and reformatting Migrate to SCSS Dec 27, 2023
@Leland Leland force-pushed the style-tweaks branch 4 times, most recently from f1c0014 to 009e9d1 Compare December 27, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant