Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rowen Trombo's Submission of Code Challenge #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rentrombo
Copy link

Overview

Completed the steps outlined in the README file and adjusted as necessary for testing passes. Outside of the steps in README changes included:
-Minor updates to install newest versions in Dockerfile and .ymp files
-Update to API url in 'templates/urls.py' to match that url given in 'templates/parserator_web/index.html'

Demo

Updating for 3.8 import in Dockerfile
image
image

in 'templates/parserator_web/index.html'
image

in 'templates/urls.py'
image

Notes

I used heavier commenting than may be expected for best practice to be as explantory as possible with my edits.

Testing Instructions

To start testing create the Docker build in Command Prompt:

docker-compose build

Next, run the app:

docker-compose up

You can run the tests using Docker:

docker-compose -f docker-compose.yml -f tests/docker-compose.yml run --rm app

The test results should look as so:
image

Please note: the XFAIL errors are referring to expected to fail errors
Also note the [NOTRUN] tests are referring to tests not run due to yield not being supported by the current version of pytest

rentrombo and others added 4 commits July 20, 2024 15:51
note on feature branch
spelling fix
applicant note ion feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant