Rowen Trombo's Submission of Code Challenge #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Completed the steps outlined in the README file and adjusted as necessary for testing passes. Outside of the steps in README changes included:
-Minor updates to install newest versions in Dockerfile and .ymp files
-Update to API url in 'templates/urls.py' to match that url given in 'templates/parserator_web/index.html'
Demo
Updating for 3.8 import in Dockerfile
in 'templates/parserator_web/index.html'
in 'templates/urls.py'
Notes
I used heavier commenting than may be expected for best practice to be as explantory as possible with my edits.
Testing Instructions
To start testing create the Docker build in Command Prompt:
Next, run the app:
You can run the tests using Docker:
The test results should look as so:
Please note: the XFAIL errors are referring to expected to fail errors
Also note the [NOTRUN] tests are referring to tests not run due to
yield
not being supported by the current version ofpytest