Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoeDelBalzo submission -- added a FROM JOE txt note #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .babelrs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": ["@babel/preset-env"]
}
32 changes: 23 additions & 9 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,28 @@ module.exports = {
globals: {
__PATH_PREFIX__: true,
},
extends: [
"eslint:recommended",
"plugin:prettier/recommended", // Add this line to use Prettier's recommended configuration
],
plugins: ["prettier"], // Add this line to include the Prettier plugin
rules: {
"indent": ["error", 2],
"prettier/prettier": "error", // Add this line to show Prettier errors as ESLint errors
indent: ["error", 2],
"no-console": "off",
"strict": ["error", "global"],
"curly": "warn",
"semi": ["error", "never"],
"space-in-parens": ["error", "never"],
"space-before-function-paren": ["error", "always"],
"space-before-blocks": ["error", "always"]
}
}
strict: ["error", "global"],
curly: "warn",
semi: ["error", "never"],
"space-in-parens": "off", // Turn off this rule
"space-before-function-paren": "off", // Turn off this rule
"space-before-blocks": ["error", "always"],
},
parserOptions: {
ecmaVersion: 2020,
sourceType: "module",
},
env: {
browser: true,
es6: true,
},
};
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,4 @@ venv.bak/

# mypy
.mypy_cache/
node_modules/
10 changes: 9 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ FROM python:3.8

# Add the NodeSource PPA
# (see: https://github.com/nodesource/distributions/blob/master/README.md)
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash -
RUN curl -sL https://deb.nodesource.com/setup_18.x | bash -

# Install any additional OS-level packages you need via apt-get. RUN statements
# add additional layers to your image, increasing its final size. Keep your
Expand Down Expand Up @@ -41,10 +41,18 @@ RUN npm install
# Copy the contents of the current host directory (i.e., our app code) into
# the container.
COPY . /app
COPY ./docker-entrypoint.sh /app/docker-entrypoint.sh

RUN ls -la /app/docker-entrypoint.sh
RUN chmod +x /app/docker-entrypoint.sh
RUN ls -la /app/docker-entrypoint.sh


# Add a bogus env var for the Django secret key in order to allow us to run
# the 'collectstatic' management command
ENV DJANGO_SECRET_KEY 'foobar'

# Build static files into the container
RUN python manage.py collectstatic --noinput

CMD ["/app/docker-entrypoint.sh"]
9 changes: 9 additions & 0 deletions FROM JOE.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Hello!

I just wanted to give you a heads up that Django is not my primary coding framework, so my knowledge here is admittedly limited. I am extremely familiar with React and with Python, though my Python knowledge is best put to the test in Leetcode, because their array methods are so much faster and more thorough!!! :lololol:

That said, I'm an avid learner and I love being put to the test. Should I be given the opportunity to prove myself further, I will know the ins and outs of Django by the time I begin working with you in the fall.

Thank you so much for the opportunity.

Joe
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: '2.4'
version: "2.4"

services:
app:
Expand Down
2 changes: 1 addition & 1 deletion docker-entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
#!/bin/bash
set -e

if [ "$DJANGO_MANAGEPY_MIGRATE" = 'on' ]; then
Expand Down
Loading