Fix and refactor FTS field generation #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/fix-fts-fields
|
| Run status |
|
| Run duration | 10m 30s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
405
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/fix-fts-fields
branch
from
daff179
to
1eb4bf0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 68.38% 68.35% -0.04%
==========================================
Files 62 62
Lines 3941 3937 -4
==========================================
- Hits 2695 2691 -4
Misses 1246 1246
|
ml-evs
force-pushed
the
ml-evs/fix-fts-fields
branch
from
1eb4bf0
to
6a8feac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #997, and is related to #993
This PR improves how we choose which fields to use in the FTS.
Previously, some IDs were being included, which will no longer happen.
Also, some field names were being added by aliases that are not present in the database, so were excluded (mostly starting materials fields).