-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoginDetails alignment when a user is unverified #984
Conversation
1a11910
to
86706df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 62 62
Lines 3955 3955
=======================================
Hits 2709 2709
Misses 1246 1246 |
datalab Run #2776
Run Properties:
|
Project |
datalab
|
Branch Review |
bc/fix-logindetails-alignment
|
Run status |
Passed #2776
|
Run duration | 06m 18s |
Commit |
f2d3273479 ℹ️: Merge f91794dba3f6d95473a35b4bf657657269d07070 into 24bb0f9cb7f77695eb0ed656c64c...
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
405
|
View all changes introduced in this branch ↗︎ |
f227607
to
7c99d69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use data-testid here, as suggested
0a0065d
to
f91794d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks!
Fix the alignment of LoginDetails when an unverified user is logged in