Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoginDetails alignment when a user is unverified #984

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

BenjaminCharmes
Copy link
Contributor

Fix the alignment of LoginDetails when an unverified user is logged in

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (24bb0f9) to head (f91794d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files          62       62           
  Lines        3955     3955           
=======================================
  Hits         2709     2709           
  Misses       1246     1246           

@BenjaminCharmes BenjaminCharmes added webapp For issues/PRs pertaining to the web interface priority/low labels Nov 4, 2024
Copy link

cypress bot commented Nov 4, 2024

datalab    Run #2776

Run Properties:  status check passed Passed #2776  •  git commit f2d3273479 ℹ️: Merge f91794dba3f6d95473a35b4bf657657269d07070 into 24bb0f9cb7f77695eb0ed656c64c...
Project datalab
Branch Review bc/fix-logindetails-alignment
Run status status check passed Passed #2776
Run duration 06m 18s
Commit git commit f2d3273479 ℹ️: Merge f91794dba3f6d95473a35b4bf657657269d07070 into 24bb0f9cb7f77695eb0ed656c64c...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the bc/fix-logindetails-alignment branch from f227607 to 7c99d69 Compare November 4, 2024 18:39
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use data-testid here, as suggested

@ml-evs ml-evs force-pushed the bc/fix-logindetails-alignment branch from 0a0065d to f91794d Compare November 14, 2024 11:31
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

@ml-evs ml-evs merged commit 5dc4e2c into main Nov 14, 2024
17 checks passed
@ml-evs ml-evs deleted the bc/fix-logindetails-alignment branch November 14, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants