Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schemas to dynamically display UI #953

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Oct 21, 2024

Related to #920
Closes #952

First draft (not finished yet) maybe it's not what you had in mind.
To discuss !

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.33%. Comparing base (21ed72d) to head (d8ccda1).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/info.py 60.86% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   68.38%   68.33%   -0.05%     
==========================================
  Files          62       62              
  Lines        3928     3951      +23     
==========================================
+ Hits         2686     2700      +14     
- Misses       1242     1251       +9     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/info.py 82.41% <60.86%> (-7.44%) ⬇️

... and 2 files with indirect coverage changes

Update routes with correct names
Copy link

cypress bot commented Oct 21, 2024

datalab    Run #2688

Run Properties:  status check failed Failed #2688  •  git commit bfc9127c2d ℹ️: Merge d8ccda1c5bf153a2644a003297ff7bc5fb1fba6f into b38c99f404acff7622653b2e8730...
Project datalab
Branch Review bc/use-schemas-endpoint
Run status status check failed Failed #2688
Run duration 07m 02s
Commit git commit bfc9127c2d ℹ️: Merge d8ccda1c5bf153a2644a003297ff7bc5fb1fba6f into b38c99f404acff7622653b2e8730...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 54
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 84
View all changes introduced in this branch ↗︎

Tests for review

Failed  batchSampleFeature.cy.js • 7 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Batch cell creation > creates a batch of cells using the template id, name, date, copyFrom, and components Test Replay Screenshots
Failed  editPage.cy.js • 7 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Checks editing the sample edit page Test Replay Screenshots
Edit Page > adds a chemical formula to component1 Test Replay Screenshots
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots
Failed  equipment.cy.js • 1 failed test • End-to-end tests (chrome)

View Output

Test Artifacts
Equipment edit page > modifies some data in a sample Test Replay Screenshots
Failed  sampleTablePage.cy.js • 3 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Advanced sample creation features > modifies some data in the second sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Test Replay Screenshots
Failed  batchSampleFeature.cy.js • 7 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Batch cell creation > creates a batch of cells using the template id, name, date, copyFrom, and components Test Replay Screenshots

The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.

@ml-evs ml-evs added this to the v0.6.x milestone Oct 26, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far -- as discussed, please update this PR with the final changes from #941

Then:

  • let's add this as a /next edit page alongside the current one
  • see how much hardcoding you can remove at this point, but don't worry too much, e.g., this edit page should not use the SampleInformation style component, but instead should have some vague sections that you can put your fields into
  • once this is working, we can try it with entirely custom schemas and figure out what kind of hints we need to put in the schemas themselves around sizing/ordering/styling of fields as components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dynamic schema info in UI
2 participants