-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use schemas to dynamically display UI #953
base: main
Are you sure you want to change the base?
Conversation
544bed7
to
4125278
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 68.38% 68.33% -0.05%
==========================================
Files 62 62
Lines 3928 3951 +23
==========================================
+ Hits 2686 2700 +14
- Misses 1242 1251 +9
|
Update routes with correct names
e4a8237
to
ffc68d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far -- as discussed, please update this PR with the final changes from #941
Then:
- let's add this as a
/next
edit page alongside the current one - see how much hardcoding you can remove at this point, but don't worry too much, e.g., this edit page should not use the
SampleInformation
style component, but instead should have some vague sections that you can put your fields into - once this is working, we can try it with entirely custom schemas and figure out what kind of hints we need to put in the schemas themselves around sizing/ordering/styling of fields as components.
Related to #920
Closes #952
First draft (not finished yet) maybe it's not what you had in mind.
To discuss !