Add component tests #872
Merged
Add component tests #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminCharmes
force-pushed
the
bc/components_test
branch
from
4ab5cf6
to
e331773
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 62 62
Lines 3890 3890
=======================================
Hits 2650 2650
Misses 1240 1240 |
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/components_test
|
| Run status |
|
| Run duration | 06m 40s |
| Commit |
|
| Committer | Benjamin Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
393
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
reviewed
Sep 6, 2024
ml-evs
reviewed
Sep 6, 2024
ml-evs
force-pushed
the
bc/components_test
branch
from
7b1b23a
to
bfd50f1
Compare
ml-evs
previously approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Fantastic, thanks @BenjaminCharmes! I haven't reviewed each test in great detail but will have a go at extending them myself.
ml-evs
force-pushed
the
bc/components_test
branch
from
bfd50f1
to
b897abb
Compare
ml-evs
force-pushed
the
bc/components_test
branch
from
b897abb
to
fdbdd52
Compare
ml-evs
approved these changes
Sep 6, 2024
ml-evs
added
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #794
I've started writing tests on some components, trying to test as many things as possible. Feedback welcome.
Components covered by test: