Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out b64-encoded data before sending to LLM #870

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 4, 2024

Closes #869

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.12%. Comparing base (42b5c71) to head (5c6a401).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/pydatalab/apps/chat/blocks.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          62       62           
  Lines        3890     3890           
=======================================
  Hits         2650     2650           
  Misses       1240     1240           
Files with missing lines Coverage Δ
pydatalab/pydatalab/apps/chat/blocks.py 20.16% <0.00%> (ø)

Copy link

cypress bot commented Sep 4, 2024

datalab    Run #2361

Run Properties:  status check passed Passed #2361  •  git commit 17898cf752 ℹ️: Merge 5c6a401a7d94f723646793ee836fc88e89dae7df into 3d730785129775f2ff6ca6ca24a7...
Project datalab
Branch Review fix-chatblock
Run status status check passed Passed #2361
Run duration 04m 39s
Commit git commit 17898cf752 ℹ️: Merge 5c6a401a7d94f723646793ee836fc88e89dae7df into 3d730785129775f2ff6ca6ca24a7...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit af5aa69 into main Sep 4, 2024
19 checks passed
@ml-evs ml-evs deleted the fix-chatblock branch September 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base64 encoded images are not filtered out when interacting with the chat block
1 participant