-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status field for items and equipment #866
Draft
BenjaminCharmes
wants to merge
5
commits into
main
Choose a base branch
from
bc/items_status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 68.12% 68.21% +0.09%
==========================================
Files 62 62
Lines 3890 3914 +24
==========================================
+ Hits 2650 2670 +20
- Misses 1240 1244 +4
|
BenjaminCharmes
force-pushed
the
bc/items_status
branch
from
September 3, 2024 12:33
72c4ab6
to
9150110
Compare
datalab Run #2378
Run Properties:
|
Project |
datalab
|
Branch Review |
bc/items_status
|
Run status |
Passed #2378
|
Run duration | 04m 58s |
Commit |
9ca74753d8 ℹ️: Merge af0dead7e187576ef61ccfde8d4ef96c675b4a10 into aecdc32b98e9d5d0182a528236cd...
|
Committer | Benjamin Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
132
|
View all changes introduced in this branch ↗︎ |
BenjaminCharmes
added
enhancement
New feature or request
API
For issues/PRs pertaining to the API
webapp
For issues/PRs pertaining to the web interface
labels
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
For issues/PRs pertaining to the API
blocked
enhancement
New feature or request
webapp
For issues/PRs pertaining to the web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #764
Add ItemStatus enum:
Add EquipmentStatus enum:
Add Status to items and equipment edit page (badge: Need to decide badge name and color. And how/where to update status
Will be added to the Prime DataTable when available