Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status field for items and equipment #866

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 3, 2024

Closes #764

  • Add ItemStatus enum:

    • PLANNED
    • ACTIVE
    • COMPLETED
    • FAILED
  • Add EquipmentStatus enum:

    • WORKING
    • BROKEN
    • BEING_FIXED
    • DEFUNCT
    • NOT_BEING_FIXED
  • Add Status to items and equipment edit page (badge: Need to decide badge name and color. And how/where to update status

  • Will be added to the Prime DataTable when available

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (42b5c71) to head (af0dead).
Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/pydatalab/routes/v0_1/items.py 64.70% 6 Missing ⚠️
pydatalab/pydatalab/models/items.py 66.66% 1 Missing ⚠️
pydatalab/pydatalab/models/utils.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   68.12%   68.21%   +0.09%     
==========================================
  Files          62       62              
  Lines        3890     3914      +24     
==========================================
+ Hits         2650     2670      +20     
- Misses       1240     1244       +4     
Files with missing lines Coverage Δ
pydatalab/pydatalab/models/equipment.py 100.00% <100.00%> (ø)
pydatalab/pydatalab/models/items.py 96.96% <66.66%> (+0.19%) ⬆️
pydatalab/pydatalab/models/utils.py 88.43% <91.66%> (+0.78%) ⬆️
pydatalab/pydatalab/routes/v0_1/items.py 81.72% <64.70%> (-0.94%) ⬇️

... and 1 file with indirect coverage changes

Copy link

cypress bot commented Sep 3, 2024

datalab    Run #2378

Run Properties:  status check passed Passed #2378  •  git commit 9ca74753d8 ℹ️: Merge af0dead7e187576ef61ccfde8d4ef96c675b4a10 into aecdc32b98e9d5d0182a528236cd...
Project datalab
Branch Review bc/items_status
Run status status check passed Passed #2378
Run duration 04m 58s
Commit git commit 9ca74753d8 ℹ️: Merge af0dead7e187576ef61ccfde8d4ef96c675b4a10 into aecdc32b98e9d5d0182a528236cd...
Committer Benjamin Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes added enhancement New feature or request API For issues/PRs pertaining to the API webapp For issues/PRs pertaining to the web interface labels Oct 8, 2024
@ml-evs ml-evs added this to the v0.6.x milestone Oct 14, 2024
@ml-evs ml-evs added the blocked label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API For issues/PRs pertaining to the API blocked enhancement New feature or request webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status field for items and equipment
2 participants