-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Python package to src-layout #865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
3 times, most recently
from
September 2, 2024 09:55
aa50729
to
f4d04ab
Compare
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
from
October 1, 2024 23:02
16a1384
to
0e15744
Compare
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
from
October 1, 2024 23:28
0e15744
to
2a2f45e
Compare
datalab Run #2516
Run Properties:
|
Project |
datalab
|
Run status |
Passed #2516
|
Run duration | 06m 22s |
Commit |
f558bd818a ℹ️: Merge 1623985d7cfa6cf7e73c8f8c7894d6788dfc64b5 into 1bc6bebf2fb53eefe00e69f36335...
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
396
|
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
3 times, most recently
from
October 2, 2024 23:20
52887ea
to
897e715
Compare
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
from
October 3, 2024 12:27
897e715
to
249336d
Compare
ml-evs
added
build
For issues/PRs pertaining to the build or deployment of the package
refactoring
For issues/PRs that refactor existing code/features
Python
labels
Oct 5, 2024
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
from
October 5, 2024 13:33
249336d
to
01386ea
Compare
BenjaminCharmes
previously approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! 👍
Remove defunct version setter Update configs for src-layout, and move server deps to default Fix mkdocs config Fix pre-commit config Fix links in pyproject Fix links in pyproject Add explicit known-first-party to avoid reformatting tests/scripts Move core server deps to defaults Tweak pyproject for src-layout `pre-commit autoupdate`, minus eslint
Remove now-unecessary docker experimental syntax pragma Matching CI ruff results; not sure why I cannot reproduce locally
Fix syntax warning in dockerfile Update dockerfile for src-layout Rejig dev api container to accommodate src-layout and add dev container healthcheck Fix docker build Disable fail fast Combine dev docker builds into one job
ml-evs
force-pushed
the
ml-evs/fix-python-package
branch
from
October 7, 2024 21:01
fac2f36
to
035c1da
Compare
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
For issues/PRs pertaining to the build or deployment of the package
Python
refactoring
For issues/PRs that refactor existing code/features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to
src
-layout is increasingly helpful for plugin development and avoids misleading imports. The main knock-on effects are related to deployment, as well as some minor tweaks needed to launch the Python server.