Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Python package to src-layout #865

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 31, 2024

Switching to src-layout is increasingly helpful for plugin development and avoids misleading imports. The main knock-on effects are related to deployment, as well as some minor tweaks needed to launch the Python server.

@ml-evs ml-evs force-pushed the ml-evs/fix-python-package branch 3 times, most recently from aa50729 to f4d04ab Compare September 2, 2024 09:55
@ml-evs ml-evs marked this pull request as ready for review October 1, 2024 23:04
@ml-evs ml-evs changed the title Switch to src-layout Switch Python package to src-layout Oct 1, 2024
@ml-evs ml-evs marked this pull request as draft October 1, 2024 23:32
Copy link

cypress bot commented Oct 2, 2024

datalab    Run #2516

Run Properties:  status check passed Passed #2516  •  git commit f558bd818a ℹ️: Merge 1623985d7cfa6cf7e73c8f8c7894d6788dfc64b5 into 1bc6bebf2fb53eefe00e69f36335...
Project datalab
Run status status check passed Passed #2516
Run duration 06m 22s
Commit git commit f558bd818a ℹ️: Merge 1623985d7cfa6cf7e73c8f8c7894d6788dfc64b5 into 1bc6bebf2fb53eefe00e69f36335...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396

@ml-evs ml-evs marked this pull request as ready for review October 2, 2024 18:52
@ml-evs ml-evs force-pushed the ml-evs/fix-python-package branch 3 times, most recently from 52887ea to 897e715 Compare October 2, 2024 23:20
@ml-evs ml-evs added build For issues/PRs pertaining to the build or deployment of the package refactoring For issues/PRs that refactor existing code/features Python labels Oct 5, 2024
BenjaminCharmes
BenjaminCharmes previously approved these changes Oct 7, 2024
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! 👍

Remove defunct version setter

Update configs for src-layout, and move server deps to default

Fix mkdocs config

Fix pre-commit config

Fix links in pyproject

Fix links in pyproject

Add explicit known-first-party to avoid reformatting tests/scripts

Move core server deps to defaults

Tweak pyproject for src-layout

`pre-commit autoupdate`, minus eslint
Remove now-unecessary docker experimental syntax pragma

Matching CI ruff results; not sure why I cannot reproduce locally
Fix syntax warning in dockerfile

Update dockerfile for src-layout

Rejig dev api container to accommodate src-layout and add dev container
healthcheck

Fix docker build

Disable fail fast

Combine dev docker builds into one job
@ml-evs ml-evs merged commit c2392a9 into main Oct 8, 2024
16 checks passed
@ml-evs ml-evs deleted the ml-evs/fix-python-package branch October 8, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build For issues/PRs pertaining to the build or deployment of the package Python refactoring For issues/PRs that refactor existing code/features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants