-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add display configuration options to the Item Graph #813
Draft
jdbocarsly
wants to merge
15
commits into
main
Choose a base branch
from
jdb/item-graph-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbocarsly
force-pushed
the
jdb/item-graph-configuration
branch
from
July 25, 2024 14:29
4570bdb
to
50fc5a1
Compare
datalab Run #2774
Run Properties:
|
Project |
datalab
|
Branch Review |
jdb/item-graph-configuration
|
Run status |
Passed #2774
|
Run duration | 06m 35s |
Commit |
c6d4e7b5cc ℹ️: Merge edf7bb8429d7493cb38b82c32ba8aad3c2831365 into 24bb0f9cb7f77695eb0ed656c64c...
|
Committer | Josh Bocarsly |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
405
|
View all changes introduced in this branch ↗︎ |
jdbocarsly
force-pushed
the
jdb/item-graph-configuration
branch
from
November 5, 2024 17:22
84aa82c
to
8cd2bd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 62 62
Lines 3955 3955
=======================================
Hits 2709 2709
Misses 1246 1246
|
jdbocarsly
force-pushed
the
jdb/item-graph-configuration
branch
from
November 5, 2024 17:37
78bbbef
to
f3a5601
Compare
ml-evs
force-pushed
the
jdb/item-graph-configuration
branch
from
November 5, 2024 17:46
f3a5601
to
13e2705
Compare
jdbocarsly
force-pushed
the
jdb/item-graph-configuration
branch
4 times, most recently
from
November 13, 2024 00:08
a848362
to
9a231b4
Compare
…s of items are selected
…through works properly
jdbocarsly
force-pushed
the
jdb/item-graph-configuration
branch
from
November 13, 2024 15:13
9a231b4
to
08a4790
Compare
…n error on component reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
ctr is not defined
when the graph is generated, then returned to.