Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add display configuration options to the Item Graph #813

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jdbocarsly
Copy link
Member

@jdbocarsly jdbocarsly commented Jul 18, 2024

Todo:

  • Add menu for graph configuration options
  • Add ability to ignore user-selected items and collections (use case: to avoid the graph clumping around trivial starting materials that are used in a large number of items)
  • Improve choice of graph algorithms to improve speed
  • Fix error ctr is not defined when the graph is generated, then returned to.
  • Make item and collection ignore dynamic (instead of regenerating the graph each time)
  • Dynamically change labels (instead of regenerating the graph)
  • Some options for coloring/styling the nodes
  • prepopulate the ItemSelect with the highest rank starting materials, since these are the most likely to need to be removed

@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch from 4570bdb to 50fc5a1 Compare July 25, 2024 14:29
Copy link

cypress bot commented Aug 1, 2024

datalab    Run #2774

Run Properties:  status check passed Passed #2774  •  git commit c6d4e7b5cc ℹ️: Merge edf7bb8429d7493cb38b82c32ba8aad3c2831365 into 24bb0f9cb7f77695eb0ed656c64c...
Project datalab
Branch Review jdb/item-graph-configuration
Run status status check passed Passed #2774
Run duration 06m 35s
Commit git commit c6d4e7b5cc ℹ️: Merge edf7bb8429d7493cb38b82c32ba8aad3c2831365 into 24bb0f9cb7f77695eb0ed656c64c...
Committer Josh Bocarsly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (24bb0f9) to head (edf7bb8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files          62       62           
  Lines        3955     3955           
=======================================
  Hits         2709     2709           
  Misses       1246     1246           
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/graphs.py 96.82% <100.00%> (ø)

@ml-evs ml-evs force-pushed the jdb/item-graph-configuration branch from f3a5601 to 13e2705 Compare November 5, 2024 17:46
@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch 4 times, most recently from a848362 to 9a231b4 Compare November 13, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants