Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow browser context menu in tinymce fields #635

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

jdbocarsly
Copy link
Member

@jdbocarsly jdbocarsly commented Mar 8, 2024

Currently, it is not possible to copy or paste from the right click context window in our tinymce fields. Tinymce has a copy/paste functionality, but apparently it is blocked in many browsers. So, the best option for now seems to be to not use tinymce's contextmenu at all, and instead enable the default browser right click.

closes #633

ml-evs
ml-evs previously approved these changes Mar 8, 2024
@ml-evs ml-evs enabled auto-merge (squash) March 8, 2024 23:43
Copy link

cypress bot commented Mar 8, 2024

Passing run #1109 ↗︎

0 26 0 0 Flakiness 0

Details:

Merge 1565fab into 9869fa4...
Project: datalab Commit: 049a49eb69 ℹ️
Status: Passed Duration: 01:38 💡
Started: Mar 9, 2024 12:30 AM Ended: Mar 9, 2024 12:32 AM

Review all test suite changes for PR #635 ↗︎

@ml-evs ml-evs self-requested a review March 8, 2024 23:47
@ml-evs ml-evs disabled auto-merge March 8, 2024 23:48
@ml-evs
Copy link
Member

ml-evs commented Mar 8, 2024

E2E errors might be real this time?

The following error originated from your application code, not from Cypress.

  > Unexpected token '<'

When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

This behavior is configurable, and you can choose to turn this off by listening to the uncaught:exception event.

https://on.cypress.io/uncaught-exception-from-application

@ml-evs ml-evs force-pushed the jdb/add-tinymce-contextmenu branch from eee2e67 to 3da5130 Compare March 9, 2024 00:00
@jdbocarsly jdbocarsly changed the title turn on "copy" and "paste" by right clicking in tiny mce fields Allow browser context menu in tinymce fields Mar 9, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could go wrong...

@ml-evs ml-evs merged commit 10411d2 into main Mar 9, 2024
8 checks passed
@ml-evs ml-evs deleted the jdb/add-tinymce-contextmenu branch March 9, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to copy and paste using right-click in TinyMCE fields
2 participants