Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS cleanup #588

Merged
merged 2 commits into from
Feb 17, 2024
Merged

CSS cleanup #588

merged 2 commits into from
Feb 17, 2024

Conversation

jdbocarsly
Copy link
Member

@jdbocarsly jdbocarsly commented Feb 15, 2024

This PR generally cleans up some of our CSS:

  • Move some component styles that were globally in App.vue to their specific SFC
  • Remove many styles that didn't seem to be in use in several SFCs (mostly because we had copied and pasted from other components, or refactored components and not moved the styles, etc.
  • Use .clickable as a global style in most cases where cursor: pointer; is required.

@jdbocarsly jdbocarsly changed the title [DRAFT] CSS cleanup and tweaks CSS cleanup Feb 15, 2024
Copy link

cypress bot commented Feb 15, 2024

Passing run #937 ↗︎

0 26 0 0 Flakiness 0

Details:

Merge 380c42b into 583a42d...
Project: datalab Commit: 9bb3070c72 ℹ️
Status: Passed Duration: 01:33 💡
Started: Feb 17, 2024 2:25 PM Ended: Feb 17, 2024 2:26 PM

Review all test suite changes for PR #588 ↗︎

@jdbocarsly jdbocarsly force-pushed the jdb/organize-css branch 2 times, most recently from fd331c8 to 4a36fad Compare February 16, 2024 20:02
@jdbocarsly jdbocarsly marked this pull request as ready for review February 16, 2024 20:02
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ml-evs ml-evs merged commit 74d64bc into main Feb 17, 2024
8 checks passed
@ml-evs ml-evs deleted the jdb/organize-css branch February 17, 2024 18:30
ml-evs pushed a commit that referenced this pull request Feb 18, 2024
* move non-global styles from App.vue to their scoped blocks within SFCs

* remove many unused css styles and use the global "clickable" class most places where "cursor: pointer"  was used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants