Remote filesystem scanning improvements #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/fix-remotes
branch
from
933464c
to
713c034
Compare
Passing run #408 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
ml-evs
force-pushed
the
ml-evs/fix-remotes
branch
7 times, most recently
from
1156919
to
c17d734
Compare
…emote endpoint - Return remote filesystem error at top level - Clearer remote error messages - Improve remote sync error handling - Upgrade failed sync alert in UI to an error
ml-evs
force-pushed
the
ml-evs/fix-remotes
branch
from
c17d734
to
574cd44
Compare
ml-evs
changed the title
ml-evs
added
server
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a series of fixes for remote filesystems, in particular making them more robust to expected failures, e.g., host key changes or folders being removed.
Previously, an JSON unhandled error regarding a single remote would break the entire
/list-remote-directoriesresponse, but now the error is nested within that remote (closes #428).It adds an admin task
invoke admin.check-remotesthat can check the sync status of remotes individually using a new endpoint for listing a single remote (could be used in the future by the app for selective syncing).