Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat improvements #414

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Chat improvements #414

merged 4 commits into from
Jun 30, 2023

Conversation

jdbocarsly
Copy link
Member

A few improvements to the chatblock:

-The prompt is tweaked to work better (shorter intro message, and more likely to produce mermaid code that compiles)
-The block title is changed to "virtual assistant"
-"show prompts" has been changed to "show advanced" and also allows the user to set the temperature and see the model name.
-fixed a bug in field_utils.js where values couldn't be set to 0.

@jdbocarsly jdbocarsly requested a review from ml-evs as a code owner June 30, 2023 17:22
@cypress
Copy link

cypress bot commented Jun 30, 2023

Passing run #366 ↗︎

0 44 0 0 Flakiness 0

Details:

Merge a67ad5c into 9d6eba4...
Project: datalab Commit: cfe87adac8 ℹ️
Status: Passed Duration: 04:45 💡
Started: Jun 30, 2023 9:24 PM Ended: Jun 30, 2023 9:28 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge these myself, otherwise looks good! Can also pin the model to 0301 in this pr

pydatalab/pydatalab/apps/chat/blocks.py Outdated Show resolved Hide resolved
pydatalab/pydatalab/apps/chat/blocks.py Outdated Show resolved Hide resolved
pydatalab/pydatalab/apps/chat/blocks.py Outdated Show resolved Hide resolved
@jdbocarsly
Copy link
Member Author

After fixing the typos the chatbot is behaving poorly again 🤦‍♂️

@jdbocarsly
Copy link
Member Author

After fixing the typos the chatbot is behaving poorly again 🤦‍♂️

Ok, seem to have fixed the behavior now.

jdbocarsly and others added 3 commits June 30, 2023 20:18
add ability to change temperature in the frontend
Co-authored-by: Matthew Evans <[email protected]>

Co-authored-by: Matthew Evans <[email protected]>

Co-authored-by: Matthew Evans <[email protected]>

tweak prompt to work well after typos
@jdbocarsly
Copy link
Member Author

I rebased into related commits, but then for some reason the co-authorship with @ml-evs seems to not be showing up (except in the commit message). Besides that I think it should be ready to go.

@ml-evs
Copy link
Member

ml-evs commented Jun 30, 2023

Can you update MODEL here too? I will approve now anyway

ml-evs
ml-evs previously approved these changes Jun 30, 2023
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@jdbocarsly
Copy link
Member Author

Can you update MODEL here too? I will approve now anyway

Ok, I actually pinned to the current version now (gpt-3.5-turbo-0613) since that works with the new prompt and I believe is a bit cheaper. Of course, we can also make this configurable (and even user-selectable) in the future.

@jdbocarsly jdbocarsly merged commit f820ba8 into main Jun 30, 2023
@jdbocarsly jdbocarsly deleted the jdb/chat_improvements branch June 30, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants