Skip to content

Commit

Permalink
chore: fix param typo in function process_left_or_full_join_null_block (
Browse files Browse the repository at this point in the history
  • Loading branch information
lichuang committed Jun 30, 2024
1 parent 1231561 commit f09b338
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ impl HashJoinProbeState {
#[allow(clippy::too_many_arguments)]
fn process_left_or_full_join_null_block(
&self,
matched_idx: usize,
unmatched_idx: usize,
input: &DataBlock,
probe_indexes: &[u32],
probe_state: &mut ProbeBlockGenerationState,
Expand All @@ -410,17 +410,17 @@ impl HashJoinProbeState {
let probe_block = if probe_state.is_probe_projected {
let mut probe_block = DataBlock::take(
input,
&probe_indexes[0..matched_idx],
&probe_indexes[0..unmatched_idx],
&mut probe_state.string_items_buf,
)?;
// For full join, wrap nullable for probe block
if self.hash_join_state.hash_join_desc.join_type == JoinType::Full {
let nullable_probe_columns = probe_block
.columns()
.iter()
.map(|c| wrap_true_validity(c, matched_idx, &probe_state.true_validity))
.map(|c| wrap_true_validity(c, unmatched_idx, &probe_state.true_validity))
.collect::<Vec<_>>();
probe_block = DataBlock::new(nullable_probe_columns, matched_idx);
probe_block = DataBlock::new(nullable_probe_columns, unmatched_idx);
}
Some(probe_block)
} else {
Expand All @@ -438,14 +438,14 @@ impl HashJoinProbeState {
value: Value::Scalar(Scalar::Null),
})
.collect(),
matched_idx,
unmatched_idx,
);
Some(null_build_block)
} else {
None
};

Ok(self.merge_eq_block(probe_block, build_block, matched_idx))
Ok(self.merge_eq_block(probe_block, build_block, unmatched_idx))
}

#[inline]
Expand Down

0 comments on commit f09b338

Please sign in to comment.