fix(Alert): Ship Name can be None

dataforgoodfr · Sep 24, 2023 · f27a29f · f27a29f
1 parent fcdd6df
commit f27a29f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -1,7 +1,7 @@
 VERSION ?= 1.0.0
 
 BLOOM_DEV_DOCKER = @docker run --name bloom-test  --mount type=bind,source="$(shell pwd)",target=/source_code --env-file ./.env.test --network=bloom_net
-BLOOM_PRODUCTION_DOCKER = @docker run --mount type=bind,source="$(shell pwd)",target=/source_code --env-file ./.env --log-driver json-file --log-opt max-size=1g --log-opt max-file=3 --entrypoint /entrypoint.sh
+BLOOM_PRODUCTION_DOCKER = @docker run --mount type=bind,source="$(shell pwd)",target=/source_code --env-file ./.env --log-driver json-file --log-opt max-size=10M --log-opt max-file=3 --entrypoint /entrypoint.sh
 
 build:
 	@docker build -t d4g/bloom:${VERSION} --platform linux/amd64  -f docker-env/Dockerfile .

diff --git a/bloom/domain/alert.py b/bloom/domain/alert.py
@@ -4,7 +4,7 @@
 
 
 class Alert(BaseModel):
-    ship_name: str
+    ship_name: str | None
     mmsi: int
     last_position_time: datetime
     position: str

diff --git a/bloom/usecase/GenerateAlerts.py b/bloom/usecase/GenerateAlerts.py
@@ -59,7 +59,7 @@ def send_slack_alert(
                                 {
                                         "type": "mrkdwn",
                                         "text": "*Name of the vessel:*\\n"""
-            + alert.ship_name
+            + (alert.ship_name or "None")
             + """"
                                 },
                                 {