Loosen OpenTelemetry dependency version constraint #216
Conversation
When using the datacontract-cli as a library dependency, OpenTelemetry may well be already a dependency of the dependee. The previous dependency constraint allowed only other patch versions of OpenTelemetry to be used. However, other minor versions should also be compatible. As such, the dependency constraints for the OpenTelemetry OTLP exporters have been loosened to allow minor version upgrades.
|
The tests are failing. There seems to be an issue with Soda and their open telemetry. |
Soda requires the `distutils` module. As this has been removed with Python 3.12, `setuptools` is required as a drop-in replacement.
|
I did some investigation: The deprecated Soda is still using it in from distutils.util import strtoboolAs it so happens, older versions of the OpenTelemetry SDK had a dependency to Newer versions of OpenTelemetry no longer have the Actually, I think Soda should fix this issue upstream. However, I've added a dependency to |
|
Is there smth that is blocking the merge? we are also waiting for this change. Thx |
|
I opened a ticket for soda: sodadata/soda-core#2091 |
|
Thank you for your contribution! |
When using the datacontract-cli as a library dependency, OpenTelemetry may well be already a dependency of the dependee. The previous dependency constraint allowed only other patch versions of OpenTelemetry to be used. However, other minor versions should also be compatible as of OpenTelemetry's stability guarantees.
As such, the dependency constraints for the OpenTelemetry OTLP exporters have been loosened to allow minor version upgrades.