[Fix] Tables with struct subcolumns which have dot in their name are redeployed on databricks_sql_table resource #3866 #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-venclovas
requested review from
hectorcast-db
and removed request for
a team
mgyucht
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Thank you for raising this PR. The code changes look fine, but we should definitely add a test to ensure this works as expected. You mentioned running internal integration tests. Can you add one in internal/acceptance/sql_table_test.go? The integration tests are not very straightforward to run for external contributors now, but if you can at least add one, that would be terrific, and I can help make sure it works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backticks are removed from the column type in order for struct subfield names to be compatible with the subfield names deployed. These subfields names are part of the column type. Example struct<`x.z`:string> == struct<x.z:string>
Tests
make testrun locallytested using internal integration tests where tables were created and terraform plans were reviewed to have no changes.