[Internal] Migrate databricks_clusters data source to plugin framework
#3998
+341
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricks into migrate-cluster-plugin-framework
…ricks into migrate-cluster-plugin-framework
…ricks into migrate-cluster-plugin-framework
…ricks into migrate-cluster-plugin-framework
tanmay-db
requested review from
mgyucht
and removed request for
a team and
mgyucht
mgyucht
reviewed
Sep 5, 2024
| } | ||
|
|
||
| func (d *ClustersDataSource) Metadata(ctx context.Context, req datasource.MetadataRequest, resp *datasource.MetadataResponse) { | ||
| resp.TypeName = "databricks_clusters_pluginframework" |
Comment on lines
+63
to
+65
| if apierr.IsMissing(err) { | ||
| resp.State.RemoveResource(ctx) | ||
| } |
There was a problem hiding this comment.
Would this happen? Is it an error if there are no clusters? (Probably not.)
Comment on lines
+74
to
+77
| if name_contains != "" && !match_name { | ||
| continue | ||
| } | ||
| ids = append(ids, types.StringValue(v.ClusterId)) |
There was a problem hiding this comment.
strings.Contains(any string, "") should always be true.
Suggested change
| if name_contains != "" && !match_name { | |
| continue | |
| } | |
| ids = append(ids, types.StringValue(v.ClusterId)) | |
| if match_name { | |
| ids = append(ids, types.StringValue(v.ClusterId)) | |
| } |
| } | ||
|
|
||
| ids := make([]types.String, 0, len(clusters)) | ||
| name_contains := strings.ToLower(clustersInfo.ClusterNameContains.ValueString()) |
| type ClusterInfo struct { | ||
| ClusterId types.String `tfsdk:"cluster_id" tf:"optional,computed"` | ||
| Name types.String `tfsdk:"cluster_name" tf:"optional,computed"` | ||
| ClusterInfo *compute_tf.ClusterDetails `tfsdk:"cluster_info" tf:"optional,computed"` |
There was a problem hiding this comment.
I think we should also try adding a proto level annotation for making a field computed in the tf configuration, so the generated tfsdk structs will have these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
databricks_clusterdata source to plugin framework #3988Changes
Migrate
databricks_clustersdata source to plugin frameworkTests
Integration tests are passing.
make testrun locallydocs/folderinternal/acceptance