Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for files with a .(resource-name).yml extension #1780

Merged
merged 38 commits into from
Oct 7, 2024
Merged

Add validation for files with a .(resource-name).yml extension #1780

merged 38 commits into from
Oct 7, 2024

Commits on Sep 24, 2024

  1. Modify SetLocation test utility to take full locations as argument

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    aa51b63 View commit details
    Browse the repository at this point in the history

  2. Add detection and info diagnostic for convention for `.<resource-type… 

    …>.yml` files
    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    667fe6b View commit details
    Browse the repository at this point in the history

  3. -

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    458dbfb View commit details
    Browse the repository at this point in the history

  4. more wip on making it work

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5c351d7 View commit details
    Browse the repository at this point in the history

  5. -

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e9426be View commit details
    Browse the repository at this point in the history

  6. add unit tests

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fa6b68c View commit details
    Browse the repository at this point in the history

  7. add info block

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ccbd199 View commit details
    Browse the repository at this point in the history

  8. cleanup todos

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3571410 View commit details
    Browse the repository at this point in the history

  9. fix failing tests

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f3d7f09 View commit details
    Browse the repository at this point in the history

  10. return if diags has error

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5bf9163 View commit details
    Browse the repository at this point in the history

  11. fix logic for dedup

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e31dcc2 View commit details
    Browse the repository at this point in the history

  12. fix windows test

    @shreyas-goenka
    shreyas-goenka committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    894f4aa View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. -

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fd01824 View commit details
    Browse the repository at this point in the history

  2. split into summary and detail

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5308ad8 View commit details
    Browse the repository at this point in the history

  3. directly pass config value

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d14b1e2 View commit details
    Browse the repository at this point in the history

  4. convert inline tests to files

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4734249 View commit details
    Browse the repository at this point in the history

  5. fix failing tests

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d9cf582 View commit details
    Browse the repository at this point in the history

  6. complete info to recommendation

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6040e58 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin' into detect-convention

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4cc0dd1 View commit details
    Browse the repository at this point in the history

  8. address comments

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fec73db View commit details
    Browse the repository at this point in the history

  9. add comment

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3203858 View commit details
    Browse the repository at this point in the history

  10. -

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    28917eb View commit details
    Browse the repository at this point in the history

  11. make unit test package separate

    @shreyas-goenka
    shreyas-goenka committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4373e7b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. add test for multiple resources

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    65ad2f0 View commit details
    Browse the repository at this point in the history

  2. fail -> not match

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b4bd47f View commit details
    Browse the repository at this point in the history

  3. address comments

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dd28a56 View commit details
    Browse the repository at this point in the history

  4. -

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    14e73ac View commit details
    Browse the repository at this point in the history

  5. remove todo

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e22ba75 View commit details
    Browse the repository at this point in the history

  6. account for the oxford comma

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    367048b View commit details
    Browse the repository at this point in the history

  7. terser recommendation message

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dd20a52 View commit details
    Browse the repository at this point in the history

  8. merge

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dd10eed View commit details
    Browse the repository at this point in the history

  9. -

    @shreyas-goenka
    shreyas-goenka committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    90f360b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. address comments

    @shreyas-goenka
    shreyas-goenka committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a737977 View commit details
    Browse the repository at this point in the history

  2. Update bundle/config/loader/process_include.go 

    Co-authored-by: Lennart Kats (databricks) <[email protected]>
    @shreyas-goenka @lennartkats-db
    shreyas-goenka and lennartkats-db authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d064566 View commit details
    Browse the repository at this point in the history

  3. Update bundle/config/loader/process_include.go 

    Co-authored-by: Lennart Kats (databricks) <[email protected]>
    @shreyas-goenka @lennartkats-db
    shreyas-goenka and lennartkats-db authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b288b07 View commit details
    Browse the repository at this point in the history

  4. Update bundle/config/loader/process_include.go 

    Co-authored-by: Lennart Kats (databricks) <[email protected]>
    @shreyas-goenka @lennartkats-db
    shreyas-goenka and lennartkats-db authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b1d7c7b View commit details
    Browse the repository at this point in the history

  5. Update bundle/config/loader/process_include.go 

    Co-authored-by: Lennart Kats (databricks) <[email protected]>
    @shreyas-goenka @lennartkats-db
    shreyas-goenka and lennartkats-db authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    361f590 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into detect-convention

    @shreyas-goenka
    shreyas-goenka authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    caa8d64 View commit details
    Browse the repository at this point in the history