Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref validator refactoring #77

Merged
merged 14 commits into from
Sep 19, 2024
Merged

Ref validator refactoring #77

merged 14 commits into from
Sep 19, 2024

Conversation

donaldcampbelljr
Copy link
Member

No description provided.

donaldcampbelljr
donaldcampbelljr commented Sep 19, 2024
View reviewed changes
Copy link
Member Author

@donaldcampbelljr donaldcampbelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for reworking this to pydantic and adding a test.

@khoroshevskyi khoroshevskyi merged commit e34e4af into dev_ref_genome_validator Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoroshevskyi khoroshevskyi khoroshevskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldcampbelljr @khoroshevskyi