wrangler e2e tests #665
Merged
wrangler e2e tests #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
Wrangler_parsing_1
branch
4 times, most recently
from
2ccb508
to
20e551a
Compare
vanathi-g
requested changes
Oct 4, 2023
| "scope": "SYSTEM" | ||
| }, | ||
| "properties": { | ||
| "directives": "parse-timestamp :time\nparse-as-currency :price :newprice\nformat-as-currency :newprice :format_price\nparse-as-simple-date :create_date yyyy-MM-dd\nparse-as-simple-date :update_date yyyy-MM-dd\ndiff-date create_date update_date diff_date\ntimestamp-to-datetime :update_date\nrename newprice id", |
There was a problem hiding this comment.
Use v2 grammar for diff-date to avoid confusion:
diff-date :create_date :update_date :diff_date
There was a problem hiding this comment.
added @d7c0e9a2f6f220bd70bb2195b86e486118081eac
| @@ -0,0 +1,180 @@ | |||
| { | |||
| "name": "parse_HL7_Wrangler", | |||
| # the License. | ||
|
|
||
| @Wrangler_Required | ||
| Feature: Wrangler - Run time scenarios for parse as Fixedlength |
There was a problem hiding this comment.
nit: parse as fixed length
| "scope": "SYSTEM" | ||
| }, | ||
| "properties": { | ||
| "directives": "parse-as-fixed-length :fixedlength 2,4,5,3\nsplit-url url\nwrite-as-csv :url_protocol\nurl-encode :url\nurl-decode :url\nencode base32 fixedlength\ndecode base32 fixedlength_encode_base32\nsplit-to-columns :url_query '='\nrename fixedlength_2 id\nfilter-rows-on condition-true fixedlength_4 !~ 'XYZ'", |
There was a problem hiding this comment.
Use v2 grammar for directives:
split-url :url
encode base32 :fixedlength
decode base32 :fixedlength_encode_base32
rename :fixedlength_2 :id
vanathi-g
approved these changes
Oct 5, 2023
AnkitCLI
force-pushed
the
Wrangler_parsing_1
branch
from
5908948
to
be1873d
Compare
|
Merging the PR as requested by the team. |
Vipinofficial11
merged commit ad7736c
into
data-integrations:develop
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrangler e2e tests for datatype,Hl7 and fixedlength parsers.