Partially supported directives #655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanathi-g
requested changes
Aug 1, 2023
| @@ -105,4 +109,19 @@ public static String getColumnTypeExp(String toType, String column, @Nullable In | |||
| return column; | |||
| } | |||
| } | |||
|
|
|||
| public static List<String> generateListCols(RelationalTranformContext relationalTranformContext) { | |||
There was a problem hiding this comment.
Can rename to generateColumnList or generateColumnNameList
Comment on lines
116
to
122
| IntStream.range(0, Math.min(columnNames.size(), columns.size())) | ||
| .forEach(i -> columnExpMap.put(columns.get(i), expressionFactory.get().compile(columnNames.get(i)))); | ||
|
|
||
| if (columnNames.size() > columns.size()) { | ||
| IntStream.range(columns.size(), columnNames.size()) | ||
| .forEach(i -> columnExpMap.put(columnNames.get(i), expressionFactory.get().compile(columnNames.get(i)))); | ||
| } |
There was a problem hiding this comment.
can move to a function with a simple for loop
| return relation.select(colmap); | ||
| } | ||
|
|
||
| public static Map<String, Expression> generateCleanseColumnMap(Collection columns, |
| if (!expressionFactory.isPresent()) { | ||
| return new InvalidRelation("Cannot find an Expression Factory"); | ||
| } | ||
| List<String> columnNames = SqlExpressionGenerator.generateListCols(relationalTranformContext); |
There was a problem hiding this comment.
So this method gets the list of input columns from the transform context, which is not really related to "generating a SQL expression". I would either suggest keeping this in a different util class or you can just rename the method to getColumnList
| } | ||
|
|
||
| return relation.setColumn("tempColumn", expressionFactory.get().compile( | ||
| String.format("if(%s, raise_error(\"Condition '%s' evaluated to true. " + |
There was a problem hiding this comment.
Can move this to a variable
wrangler-core/src/main/java/io/cdap/directives/row/RecordConditionFilter.java
Show resolved
Hide resolved
wrangler-core/src/main/java/io/cdap/directives/transformation/Decode.java
Show resolved
Hide resolved
| if (!expressionFactory.isPresent()) { | ||
| return new InvalidRelation("Cannot find an Expression Factory"); | ||
| } | ||
| if (method.toString().equalsIgnoreCase("base64")) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements relational transform for the following directives: