fix markdown errors #51

seanzhougoogle · 2022-03-29T19:04:26Z

No description provided.

rrielley76 · 2022-03-29T20:41:14Z

docs/OracleDatastream-cdcSource.md


-**Private Connection Name:** Name of the private connection. The network admins of the Google Cloud Platform project should create a VPC peering between the database VPC and the Datastream VPC (see [Use private connectivity](https://cloud.google.com/datastream/docs/source-network-connectivity-options#privateconnectivity) for details). THis is the name of the VPC peering they created. Only applicable when you choose `Private connectivity (VPC peering)` as your `Connectivity Method`.
+**Private Connection Name**: Name of the private connection. The network admins of the Google Cloud Platform project should create a VPC peering between the database VPC and the Datastream VPC (see [Use private connectivity](https://cloud.google.com/datastream/docs/source-network-connectivity-options#privateconnectivity) for details). THis is the name of the VPC peering they created. Only applicable when you choose `Private connectivity (VPC peering)` as your `Connectivity Method`.


Can we change "should" to "must" so it's clear and translates in the future?
Can we change the xref to say "For more information, see Use private...."
Change "THis" change to "This"
Can "they" in the last line change to "...the VPC peering the network admins created..."

rrielley76 · 2022-03-29T20:45:00Z

docs/OracleDatastream-cdcSource.md


-**System Identifier (SID):** The system identifier(SID) of the oracle database you want to replicate data from.
+**System Identifier (SID)**: The system identifier(SID) of the oracle database you want to replicate data from.


Can you init cap "Oracle"?

rrielley76 · 2022-03-29T20:51:13Z

docs/OracleDatastream-cdcSource.md


-**Project:** The Google Cloud Platform project that has enabled the Datastream API. It will default to the value of the system property `GOOGLE_CLOUD_PROJECT` or `GCLOUD_PROJECT` for CDAP and Data Fusion Project for Data Fusion. 
+**Project**: The Google Cloud Platform project that has enabled the Datastream API. It will default to the value of the system property `GOOGLE_CLOUD_PROJECT` or `GCLOUD_PROJECT` for CDAP and Data Fusion Project for Data Fusion. 


change to "to defaults to" (delete will)
The ui default is auto-detect?
Delete second sentence and say default is auto-detect

rrielley76 · 2022-03-29T21:27:46Z

docs/OracleDatastream-cdcSource.md


-**Datastream Service Account Key:** The service account key for the service account that will be used as the identity to call the Datastream API. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion.
+**Datastream Service Account Key**: The service account key for the service account that will be used as the identity to call the Datastream API. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion.


change "will default" to "defaults"
Delete second sentence and just say Default is auto-detect.

rrielley76 · 2022-03-29T21:42:41Z

docs/OracleDatastream-cdcSource.md


-**GCS Bucket:** The GCS (Google Cloud Storage) bucket that Datastream will write its output to. If the bucket you provide doesn't exist or you leave it as empty, this plugin will create a new one in the `Project` you specified in this plugin. 
+**GCS Bucket**: The GCS (Google Cloud Storage) bucket that Datastream will write its output to. If the bucket you provide doesn't exist or you leave it as empty, this plugin will create a new one in the `Project` you specified in this plugin. 


delete "will" and say "writes".
change "new one" to "new bucket"

rrielley76 · 2022-03-29T21:44:26Z

docs/OracleDatastream-cdcSource.md


-**Path Prefix:** The GCS (Google Cloud Storage) path prefix in the bucket that Datastream will write its output to. This prefix will be prefixed to the Datastream output path. It's usually used when you want Datastream to write its output to an existing bucket and you want to easily differentiate it from other existing GCS files by its path prefix.  
+**Path Prefix**: The GCS (Google Cloud Storage) path prefix in the bucket that Datastream will write its output to. This prefix will be prefixed to the Datastream output path. It's usually used when you want Datastream to write its output to an existing bucket and you want to easily differentiate it from other existing GCS files by its path prefix.  


delete "will" and say "writes"
Change "It's usually.." to "Used when..."
Changed prefixed to "prepended"

rrielley76 · 2022-03-29T21:50:09Z

docs/OracleDatastream-cdcSource.md

@@ -53,49 +53,49 @@ See [Configure your source Oracle database](https://cloud.google.com/datastream/
 Plugin properties
 -----------

-**Use an existing Datastream stream:** Whether to let this plugin create a new Datastream stream or use an existing Datastream stream. It's recommended that you only have one Datastream stream per Oracle Database for performance concerns.
+**Use an existing Datastream stream**: Whether to let this plugin create a new Datastream stream or use an existing Datastream stream. It's recommended that you only have one Datastream stream per Oracle Database for performance concerns.


Change last sentence to "Recommended: For optimal performance, have one Datastream stream for each Oracle Database."

rrielley76 · 2022-03-29T22:00:49Z

docs/OracleDatastream-cdcSource.md


-**Connectivity Method** How you want the Datastream to connect to your database. See [Source network connectivity options](https://cloud.google.com/datastream/docs/source-network-connectivity-options) about what each option means and what you need to do for your network settings.
+**Connectivity Method**: How you want the Datastream to connect to your database. See [Source network connectivity options](https://cloud.google.com/datastream/docs/source-network-connectivity-options) about what each option means and what you need to do for your network settings.


Change to "For information about what each..., see xx"

rrielley76 · 2022-03-29T22:01:42Z

docs/OracleDatastream-cdcSource.md


-**Host (in the <b>Basic</b> section):** The hostname or IP address of your SSH tunnel bastion server. Only applicalbe when you choose `Forward SSH Tunnel` as your `Connectivity Method`.
+**Host**(in the **Basic** section): The hostname or IP address of your SSH tunnel bastion server. Only applicalbe when you choose `Forward SSH Tunnel` as your `Connectivity Method`.


change "applicalbe" to "applicable"

rrielley76 · 2022-03-29T22:03:05Z

docs/OracleDatastream-cdcSource.md


-**Private Key:** The private key Datastream will use to connect to your SSH tunnel bastion server that matches the public key assigned to it. Only applicable when you choose `Private/Public Key Pair` as your `Authentication Method`.
+**Private Key**: The private key Datastream will use to connect to your SSH tunnel bastion server that matches the public key assigned to it. Only applicable when you choose `Private/Public Key Pair` as your `Authentication Method`.


delete will and change to active voice "uses"

rrielley76 · 2022-03-29T22:30:54Z

docs/OracleDatastream-cdcSource.md


-**GCS Service Account Key:** The service account key for the service account that will be used as the identity to access GCS. Datastream will write the change stream to the GCS bucket you specified as the `GCS Bucket` property of this plugin. This service account will be used as the identity to get and create (if you want this plugin to create a new bucket) the bucket and read Datastream result from the bucket. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion. 
+**GCS Service Account Key**: The service account key for the service account that will be used as the identity to access GCS. Datastream will write the change stream to the GCS bucket you specified as the `GCS Bucket` property of this plugin. This service account will be used as the identity to get and create (if you want this plugin to create a new bucket) the bucket and read Datastream result from the bucket. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion. 


Delete last sentence and just say Default is auto-detect.

sonarcloud · 2022-11-16T17:23:04Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

fix markdown errors

2a3f732

rrielley76 reviewed Mar 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix markdown errors #51

fix markdown errors #51

seanzhougoogle commented Mar 29, 2022

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022

rrielley76 Mar 29, 2022

rrielley76 Mar 29, 2022

rrielley76 Mar 29, 2022

sonarcloud bot commented Nov 16, 2022


		Private Connection Name: Name of the private connection. The network admins of the Google Cloud Platform project should create a VPC peering between the database VPC and the Datastream VPC (see [Use private connectivity](https://cloud.google.com/datastream/docs/source-network-connectivity-options#privateconnectivity) for details). THis is the name of the VPC peering they created. Only applicable when you choose `Private connectivity (VPC peering)` as your `Connectivity Method`.
		Private Connection Name: Name of the private connection. The network admins of the Google Cloud Platform project should create a VPC peering between the database VPC and the Datastream VPC (see [Use private connectivity](https://cloud.google.com/datastream/docs/source-network-connectivity-options#privateconnectivity) for details). THis is the name of the VPC peering they created. Only applicable when you choose `Private connectivity (VPC peering)` as your `Connectivity Method`.


		System Identifier (SID): The system identifier(SID) of the oracle database you want to replicate data from.
		System Identifier (SID): The system identifier(SID) of the oracle database you want to replicate data from.


		Project: The Google Cloud Platform project that has enabled the Datastream API. It will default to the value of the system property `GOOGLE_CLOUD_PROJECT` or `GCLOUD_PROJECT` for CDAP and Data Fusion Project for Data Fusion.
		Project: The Google Cloud Platform project that has enabled the Datastream API. It will default to the value of the system property `GOOGLE_CLOUD_PROJECT` or `GCLOUD_PROJECT` for CDAP and Data Fusion Project for Data Fusion.


		Datastream Service Account Key: The service account key for the service account that will be used as the identity to call the Datastream API. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion.
		Datastream Service Account Key: The service account key for the service account that will be used as the identity to call the Datastream API. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion.


		GCS Bucket: The GCS (Google Cloud Storage) bucket that Datastream will write its output to. If the bucket you provide doesn't exist or you leave it as empty, this plugin will create a new one in the `Project` you specified in this plugin.
		GCS Bucket: The GCS (Google Cloud Storage) bucket that Datastream will write its output to. If the bucket you provide doesn't exist or you leave it as empty, this plugin will create a new one in the `Project` you specified in this plugin.


		Path Prefix: The GCS (Google Cloud Storage) path prefix in the bucket that Datastream will write its output to. This prefix will be prefixed to the Datastream output path. It's usually used when you want Datastream to write its output to an existing bucket and you want to easily differentiate it from other existing GCS files by its path prefix.
		Path Prefix: The GCS (Google Cloud Storage) path prefix in the bucket that Datastream will write its output to. This prefix will be prefixed to the Datastream output path. It's usually used when you want Datastream to write its output to an existing bucket and you want to easily differentiate it from other existing GCS files by its path prefix.


		Connectivity Method How you want the Datastream to connect to your database. See [Source network connectivity options](https://cloud.google.com/datastream/docs/source-network-connectivity-options) about what each option means and what you need to do for your network settings.
		Connectivity Method: How you want the Datastream to connect to your database. See [Source network connectivity options](https://cloud.google.com/datastream/docs/source-network-connectivity-options) about what each option means and what you need to do for your network settings.


		Host (in the <b>Basic</b> section): The hostname or IP address of your SSH tunnel bastion server. Only applicalbe when you choose `Forward SSH Tunnel` as your `Connectivity Method`.
		Host(in the Basic section): The hostname or IP address of your SSH tunnel bastion server. Only applicalbe when you choose `Forward SSH Tunnel` as your `Connectivity Method`.


		Private Key: The private key Datastream will use to connect to your SSH tunnel bastion server that matches the public key assigned to it. Only applicable when you choose `Private/Public Key Pair` as your `Authentication Method`.
		Private Key: The private key Datastream will use to connect to your SSH tunnel bastion server that matches the public key assigned to it. Only applicable when you choose `Private/Public Key Pair` as your `Authentication Method`.


		GCS Service Account Key: The service account key for the service account that will be used as the identity to access GCS. Datastream will write the change stream to the GCS bucket you specified as the `GCS Bucket` property of this plugin. This service account will be used as the identity to get and create (if you want this plugin to create a new bucket) the bucket and read Datastream result from the bucket. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion.
		GCS Service Account Key: The service account key for the service account that will be used as the identity to access GCS. Datastream will write the change stream to the GCS bucket you specified as the `GCS Bucket` property of this plugin. This service account will be used as the identity to get and create (if you want this plugin to create a new bucket) the bucket and read Datastream result from the bucket. It will default to the content of the file referred by the system property `GOOGLE_APPLICATION_CREDENTIALS` for CDAP and Data Fusion Service Account for Data Fusion.

fix markdown errors #51

Are you sure you want to change the base?

fix markdown errors #51

Conversation

seanzhougoogle commented Mar 29, 2022

rrielley76 Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022

Choose a reason for hiding this comment

rrielley76 Mar 29, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Nov 16, 2022

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading

rrielley76 Mar 29, 2022 •

edited

Loading