Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerability fix : Exclude the transitive dependency org.apache.ivy:ivy from hydrator-test #153

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Vulnerability fix : Exclude the transitive dependency org.apache.ivy:ivy from hydrator-test #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
<exclusion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The org.apache.ivy:ivy transitive dependency is present in org.apache.spark:spark-core_2.11 dependency of io.cdap.cdap:cdap-spark-core2_2.11 module. Ideally the transitive dependency should be excluded from direct dependency in CDAP's cdap-spark-core2_2.11 module. (link)
This would ensure that the vulnerability is fixed at all places.

Output of mvn dependency:tree -Dincludes='org.apache.ivy:ivy':

[INFO] \- io.cdap.cdap:hydrator-test:jar:6.9.0-SNAPSHOT:provided
[INFO]    \- io.cdap.cdap:cdap-unit-test:jar:6.9.0-SNAPSHOT:provided
[INFO]       \- io.cdap.cdap:cdap-spark-core2_2.11:jar:6.9.0-SNAPSHOT:provided
[INFO]          \- org.apache.spark:spark-core_2.11:jar:2.1.3:provided
[INFO]             \- org.apache.ivy:ivy:jar:2.4.0:provided
[INFO] ------------------------------------------------------

Copy link
Contributor

@dli357 dli357 Dec 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok assuming we don't have any tests that use this functionality. However, we might not be able to exclude this dependency from io.cdap.cdap:cdap-spark-core2_2.11 entirely because there could be users who use the Advanced Dependency Management feature.

<groupId>org.apache.ivy</groupId>
<artifactId>ivy</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
Expand Down