Fix #19
Open
Fix #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n situ. We need this because libyt does not make a copy of the names.
I don't know why there is two grid showing active particle count = 1. There should only be one particle in this run, not sure if it overlapped.
It pre-allocates buffers to store a copy of attribute data. They will free them when libyt ends.
…are not correct) The attributes are put in a new allocated buffer. It will be freed when in situ analysis are done.
This is caused by GetAttribute _shifts_ the pointer passed in when returning.
cindytsai
commented
Jun 14, 2024
cindytsai
commented
Jun 14, 2024
cindytsai
commented
Jun 14, 2024
cindytsai
commented
Jun 14, 2024
cindytsai
commented
Jun 14, 2024
|
@matthewturk , I totally forget about this PR. This PR supports active particles and derived fields (though limited to |
matthewturk
reviewed
Sep 6, 2024
|
@matthewturk I have fixed the issues. |
|
I think I should also update the version of libyt in the doc. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs, Load Active Particles and Derived Fields
Doc
sm,pt2pt.Bugs
Gammatogamma, since enzo's yt frontend readsds.gamma.velocity_unit,magnetic_unit,periodicity.EYT_PINTtoYT_LONGLONGwhen-DCONFIG_PINT_8. (Note that in this setting, MPI is mapped toMPI_LONG_LONG_INT.)Derived Fields
Temperature,Cooling_Time) and assign them as enzo inline fields. This avoids looking up grid ID when usinglibyt's generating data from C-function.Active Particles
libyt.libyt.hinParticleAttributeHandler.h. And because hdf5 is a mandatory dependency, using hdf5 data type to map to yt data type won't have any conflict.GetParticleAttributeNames,GetParticleAttributes, andGetParticleAttributesHDF5DataTypeare created inActiveParticleHelpersnamespace. They are used in libyt only. Since the active particle is created via aregister_ptypefunction layer, adding them here will not alter the original behavior of the active particle.GetParticleAttributesallocates a new data buffer and callsGetAttributeto fill in the buffer. These buffers will be freed after libyt is done. Currently, we only get the attributes that have 1 dimension. (Notice thatGetAttributeshifts the buffer pointer when returning.)