fix(consensus): vote extensions verified multiple times #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
changed the title
lklimek
force-pushed
the
feat/verify-vote-ext-caching
branch
from
61cd830
to
716f585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Right now, each vote we receive is sent to Drive using VerifyVoteExtension.
It means that if each peer has exactly the same 100 votes, and we have 10 peers, this call is executed 1000 times.
What was done?
Added check to skip verification of vote extensions if the vote was already verified and added to the VoteSet.
How Has This Been Tested?
On a "big" network.
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only