Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-active validators can't verify evidence signatures #865

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Aug 12, 2024

Issue being fixed or feature implemented

Nodes that are not active validators don't have access to public keys of validators, so they cannot verify signatures in evidence.

What was done?

  1. Non-validators don't verify signatures
  2. Non-validators don't add evidence to evidence pool, to avoid adding fake evidence

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek force-pushed the fix/non-validator-evidence-sigs branch from 87ed796 to 6ec2a50 Compare August 12, 2024 06:07
@lklimek lklimek added this to the v1.2 milestone Aug 12, 2024
@lklimek lklimek marked this pull request as ready for review August 12, 2024 07:44
@shumkov shumkov changed the title fix: don't verify evidence signatures on non-validators fix: non-active validators can't verify evidence signatures Aug 12, 2024
internal/evidence/reactor.go Outdated Show resolved Hide resolved
shumkov
shumkov previously approved these changes Aug 12, 2024
@lklimek lklimek enabled auto-merge (squash) August 12, 2024 08:31
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 29f8bb5 into v1.2-dev Aug 12, 2024
15 checks passed
@lklimek lklimek deleted the fix/non-validator-evidence-sigs branch August 12, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants