-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow delaying transactions in ResponsePrepareProposal #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
previously approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
markin-io
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
shumkov
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
ABCI App must check if the size of transactions does not exceed max limit.
If it does, it should reject the transaction. Unfortunately, only abci.TxRecord_REMOVED, action is available that removed the tx from mempool.
This should not be a problem in a system where there are many validators, as the tx should be added to next block by another proposer (which didn't remove it from mempool yet). However, for a relatively small validator set, this can lead to dropped transactions in some edge cases.
What was done?
Introduced abci.TxRecord_DELAYED, which should remove the transaction from proposal/block, while still leaving it in the mempool.
Refactored kvstore and e2e example apps to better support testing of transactions.
Refactored logs to only include hash of tx, not full tx
How Has This Been Tested?
Added e2e test that tests this feature.
Breaking Changes
None - only new action added in ResponsePrepareProposal, but the system should work just fine with apps that don't support this action (as it's in response).
Checklist:
For repository code-owners and collaborators only