fix(proto)!: remove unused SIGNED_MSG_TYPE_COMMIT (#638)

dashpay · Jun 13, 2023 · 200c050 · 200c050
1 parent 90feab0
commit 200c050
Show file tree

Hide file tree

Showing 7 changed files with 104 additions and 108 deletions.
diff --git a/abci/types/types.pb.go b/abci/types/types.pb.go
diff --git a/proto/tendermint/abci/types.proto b/proto/tendermint/abci/types.proto
@@ -346,6 +346,7 @@ message RequestProcessProposal {
   // List of information about validators that acted incorrectly.
   repeated Misbehavior misbehavior = 3 [(gogoproto.nullable) = false];
   // The block header's hash of the proposed block.
+  // It is computed as a Merkle tree from the header fields.
   bytes hash = 4;
   // The height of the proposed block.
   int64 height = 5;

diff --git a/proto/tendermint/types/types.pb.go b/proto/tendermint/types/types.pb.go
diff --git a/proto/tendermint/types/types.proto b/proto/tendermint/types/types.proto
@@ -36,8 +36,6 @@ enum SignedMsgType {
       [(gogoproto.enumvalue_customname) = "PrevoteType"];
   SIGNED_MSG_TYPE_PRECOMMIT = 2
       [(gogoproto.enumvalue_customname) = "PrecommitType"];
-  SIGNED_MSG_TYPE_COMMIT = 3
-      [(gogoproto.enumvalue_customname) = "CommitType"];
 
   // Proposals
   SIGNED_MSG_TYPE_PROPOSAL = 32

diff --git a/spec/abci++/api.md b/spec/abci++/api.md
@@ -693,7 +693,7 @@ When a validator _p_ enters Tenderdash consensus round _r_, height _h_, in which
 | txs | [bytes](#bytes) | repeated | List of transactions that have been picked as part of the proposed |
 | proposed_last_commit | [CommitInfo](#tendermint-abci-CommitInfo) |  | Info about the last commit, obtained from the information in the proposed block. |
 | misbehavior | [Misbehavior](#tendermint-abci-Misbehavior) | repeated | List of information about validators that acted incorrectly. |
-| hash | [bytes](#bytes) |  | The block header&#39;s hash of the proposed block. |
+| hash | [bytes](#bytes) |  | The block header&#39;s hash of the proposed block. It is computed as a Merkle tree from the header fields. |
 | height | [int64](#int64) |  | The height of the proposed block. |
 | round | [int32](#int32) |  | Round number for the block |
 | time | [google.protobuf.Timestamp](#google-protobuf-Timestamp) |  | Timestamp included in the proposed block. |

diff --git a/spec/consensus/signing.md b/spec/consensus/signing.md
@@ -193,7 +193,7 @@ app state using vote signature. Data needed to do the verification is:
 
 * Chain ID
 * Commit information:
-    * Type (constant, always Commit)
+    * Type (constant, always Precommit)
     * Height
     * Round
 * Hash of CanonicalBlockID

diff --git a/version/version.go b/version/version.go
@@ -11,7 +11,7 @@ const (
 	// when not using git describe. It is formatted with semantic versioning.
 	TMVersionDefault = "0.12.0-dev.2"
 	// ABCISemVer is the semantic version of the ABCI library
-	ABCISemVer = "0.20.0"
+	ABCISemVer = "0.21.0"
 
 	ABCIVersion = ABCISemVer
 )