Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warnings #1195

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix compile warnings #1195

merged 1 commit into from
Jul 6, 2023

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Jul 6, 2023

warning: using `.borrow()` on a double reference, which returns `&(&str, &xcm::v3::MultiLocation)` instead of borrowing the inner type
   --> runtime/common/src/xcm_configs.rs:128:55
    |
128 |         let hash: [u8; 32] = ("multiloc", location.borrow()).borrow().using_encoded(blake2_256);
    |                                                             ^^^^^^^^^
    |
    = note: `#[warn(suspicious_double_ref_op)]` on by default

warning: `darwinia-common-runtime` (lib) generated 1 warning
    Checking darwinia v6.3.4 (/home/bear/coding/rust-space/darwinia/node)
    Finished release [optimized] target(s) in 3.00s

warning: function `ensure_dev` is never used
   --> node/src/command.rs:915:4
    |
915 | fn ensure_dev(spec: &dyn IdentifyVariant) -> Result<()> {
    |    ^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `darwinia` (bin "darwinia") generated 1 warning
    Finished release [optimized] target(s) in 10m 42s

@boundless-forest
Copy link
Member Author

warning: /home/bear/coding/rust-space/darwinia/runtime/crab/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/message-gadget/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/runtime/darwinia/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/runtime/pangoro/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/account-migration/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/staking/traits/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/precompile/assets/Cargo.toml: unused manifest key: dev-dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/staking/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/runtime/common/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/ecdsa-authority/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/message-transact/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/precompile/deposit/Cargo.toml: unused manifest key: dev-dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/precompile/staking/Cargo.toml: unused manifest key: dev-dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/precompile/state-storage/Cargo.toml: unused manifest key: dev-dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/node/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/runtime/pangolin/Cargo.toml: unused manifest key: dependencies.codec.package
warning: /home/bear/coding/rust-space/darwinia/pallet/deposit/Cargo.toml: unused manifest key: dependencies.codec.package

No idea what these warning means yet. Leave it alone for now.

@boundless-forest boundless-forest marked this pull request as ready for review July 6, 2023 02:50
@AurevoirXavier AurevoirXavier added the U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic label Jul 6, 2023
@AurevoirXavier AurevoirXavier merged commit 23248a5 into main Jul 6, 2023
14 checks passed
@AurevoirXavier AurevoirXavier deleted the bear-chores branch July 6, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants