default-features Checker (#712)

* reformat toml & some fixes

* CI checks `default-features`

* fix as suggestion

* format output

.github/workflows/ci.yml

@@ -13,6 +13,19 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
+  check-default-features:
+    name: Check `default-features`
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: nightly
+      - name: Build checker
+        run: cargo b --manifest-path .maintain/check-default-features/Cargo.toml
+      - name: Run checker
+        run: .maintain/check-default-features/target/debug/check-default-features
+
   test:
     name: Run Tests
     runs-on: ubuntu-latest

.gitignore

@@ -7,6 +7,6 @@
 
 # Package Manager
 ## cargo
-/target
+target
 ## npm
 node_modules

.maintain/check-default-features/Cargo.toml

@@ -0,0 +1,8 @@
+[package]
+edition = "2018"
+name    = "check-default-features"
+version = "0.1.0"
+
+[dependencies]
+cargo_toml = { version = "0.9.2" }
+walkdir    = { version = "2.3.2" }

.maintain/check-default-features/src/main.rs

@@ -0,0 +1,54 @@
+// --- std ---
+use std::{env, process};
+// --- crates.io ---
+use cargo_toml::Manifest;
+use walkdir::WalkDir;
+
+fn main() {
+	let mut incomplete_dependencies = vec![];
+
+	for e in WalkDir::new(env::current_dir().unwrap())
+		.into_iter()
+		.filter_entry(|e| {
+			let n = e.file_name().to_str().unwrap();
+
+			n != "target" && !(n.starts_with('.') && !n.starts_with("./"))
+		})
+		.filter_map(|e| e.ok())
+	{
+		if e.file_name() == "Cargo.toml" {
+			let manifest = Manifest::from_path(e.path()).unwrap();
+
+			if let Some(std) = manifest.features.get("std") {
+				for (alias, dependency) in manifest.dependencies.iter() {
+					if let Some(detail) = dependency.detail() {
+						if let Some(default_features) = detail.default_features {
+							if !default_features {
+								if !std.contains(&format!("{}/std", alias)) {
+									incomplete_dependencies.push((
+										alias.to_owned(),
+										e.path()
+											.to_str()
+											.unwrap()
+											.split("common/")
+											.last()
+											.unwrap()
+											.to_owned(),
+									));
+								}
+							}
+						}
+					}
+				}
+			}
+		}
+	}
+
+	if !incomplete_dependencies.is_empty() {
+		for (alias, path) in incomplete_dependencies {
+			println!("Incomplete std feature found for `{}` at `{}`", alias, path);
+		}
+
+		process::exit(1);
+	}
+}

Cargo.toml

@@ -65,6 +65,10 @@ members = [
 	"primitives/storage",
 ]
 
+exclude = [
+	".maintain/check-default-features",
+]
+
 # The list of dependencies below (which can be both direct and indirect dependencies) are crates
 # that are suspected to be CPU-intensive, and that are unlikely to require debugging (as some of
 # their debug info might be missing) or to require to be frequently recompiled. We compile these

bin/node/bridge-primitives/pangolin/Cargo.toml

@@ -10,12 +10,11 @@ repository  = "https://github.com/darwinia-network/darwinia-common/"
 version     = "2.5.0"
 
 [dependencies]
-# bridge
-bp-messages = { default-features = false, git = "https://github.com/darwinia-network/parity-bridges-common", branch = "main" }
-bp-runtime  = { default-features = false, git = "https://github.com/darwinia-network/parity-bridges-common", branch = "main" }
-# darwinia
+# darwinia-network
 drml-primitives = { default-features = false, path = "../../primitives" }
-# substrate
+# paritytech
+bp-messages   = { default-features = false, git = "https://github.com/darwinia-network/parity-bridges-common", branch = "main" }
+bp-runtime    = { default-features = false, git = "https://github.com/darwinia-network/parity-bridges-common", branch = "main" }
 frame-support = { default-features = false, git = "https://github.com/darwinia-network/substrate", branch = "main" }
 sp-api        = { default-features = false, git = "https://github.com/darwinia-network/substrate", branch = "main" }
 sp-core       = { default-features = false, git = "https://github.com/darwinia-network/substrate", branch = "main" }
@@ -26,15 +25,9 @@ sp-std        = { default-features = false, git = "https://github.com/darwinia-n
 default = ["std"]
 
 std = [
-	"darwinia-std",
-	"substrate-std",
-]
-
-darwinia-std = [
+	# darwinia-network
 	"drml-primitives/std",
-]
-
-substrate-std = [
+	# paritytech
 	"bp-messages/std",
 	"bp-runtime/std",
 	"frame-support/std",