Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative scale for MeshShape #1841

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Allow negative scale for MeshShape #1841

merged 3 commits into from
Sep 3, 2024

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 31, 2024

This PR supports negative scaling in MeshShape as requested #1839. While it's not extensively tested yet, initial results are promising. Scaling the pelvis mesh by positive (5) and negative (-5) values worked as expected in preliminary tests.

Pelvis with scale(5, 5, 5):

Screencast.from.2024-08-31.08-19-48.mp4

Pelvis with scale(-5, -5, -5):

Screencast.from.2024-08-31.08-18-31.mp4

Resolves #1839.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 changed the base branch from main to release-6.14 August 31, 2024 15:39
@jslee02 jslee02 modified the milestones: DART 6.15.0, DART 6.14.5 Aug 31, 2024
@jslee02 jslee02 marked this pull request as ready for review August 31, 2024 17:41
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (9feb578) to head (8f2c9c9).
Report is 1 commits behind head on release-6.14.

Files with missing lines Patch % Lines
dart/dynamics/MeshShape.cpp 76.92% 3 Missing ⚠️
python/dartpy/dynamics/Shape.cpp 60.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-6.14    #1841      +/-   ##
================================================
- Coverage         61.57%   61.55%   -0.02%     
================================================
  Files               490      490              
  Lines             46021    46010      -11     
================================================
- Hits              28337    28323      -14     
- Misses            17684    17687       +3     
Files with missing lines Coverage Δ
python/dartpy/dynamics/Shape.cpp 64.72% <60.00%> (+0.03%) ⬆️
dart/dynamics/MeshShape.cpp 29.15% <76.92%> (-4.07%) ⬇️

@jslee02 jslee02 merged commit e5c8c2c into release-6.14 Sep 3, 2024
32 checks passed
@jslee02 jslee02 deleted the neg_scale branch September 3, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshShape::setScale does not accept negative values?
1 participant