Allow negative scale for MeshShape #1841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports negative scaling in MeshShape as requested #1839. While it's not extensively tested yet, initial results are promising. Scaling the pelvis mesh by positive (5) and negative (-5) values worked as expected in preliminary tests.
Pelvis with scale(5, 5, 5):
Screencast.from.2024-08-31.08-19-48.mp4
Pelvis with scale(-5, -5, -5):
Screencast.from.2024-08-31.08-18-31.mp4
Resolves #1839.
Before creating a pull request
make format
-DDART_TREAT_WARNINGS_AS_ERRORS=ON
and resolve all the compile warningsBefore merging a pull request
CHANGELOG.md