Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parentheses in config.hpp #1838

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 27, 2024

to fix #1837

Remove this line and describe this pull request. Link to relevant GitHub issues, if any.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

to fix #1837

Signed-off-by: Jeongseok (JS) Lee <[email protected]>
@jslee02 jslee02 added this to the 6.14.5 milestone Aug 27, 2024
@jslee02 jslee02 marked this pull request as ready for review August 27, 2024 21:59
@jslee02 jslee02 merged commit 9feb578 into release-6.14 Aug 27, 2024
30 checks passed
@jslee02 jslee02 deleted the jslee02-patch-1 branch August 27, 2024 21:59
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.56%. Comparing base (2b6abb5) to head (41e686f).
Report is 1 commits behind head on release-6.14.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-6.14    #1838   +/-   ##
=============================================
  Coverage         61.56%   61.56%           
=============================================
  Files               490      490           
  Lines             46021    46021           
=============================================
  Hits              28334    28334           
  Misses            17687    17687           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant