Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coupler constraint #1835

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adityapande-1995
Copy link

@adityapande-1995 adityapande-1995 commented Aug 9, 2024

This PR adds a new Coupler Constraint, to address #1756.
Most of the code here is taken from MimicMotorConstraint, with changes to excite, unexcite, applyUnitImpulse and applyImpulse.

This is still a work in progress, looking for ideas on how to write a test for this, to compare MimicMotorConstraint and CouplerConstraint cc @scpeters.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

Signed-off-by: Aditya Pande <[email protected]>
@scpeters
Copy link
Collaborator

for testing, I recommend starting with the gz-physics test (see #1756 (comment)) and then writing a custom test for dart once we have something working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants