Include CTest for BUILD_TESTING option #1819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent release of dartsim 6.14.0 is failing to build in homebrew-core due to an issue with fetching GoogleTest (see Homebrew/homebrew-core#175563 (comment)). My first thought to work around this was to build the homebrew formula with
-DBUILD_TESTING=OFF
, but that option is neither defined nor used to disable test compilation. This includesCTest
to define the option and adds logic to skip building tests whenBUILD_TESTING
is false.We could separately try to find the
googletest
homebrew formula instead of usingFetchContent
if desired, but I thinkBUILD_TESTING
is a useful option anyway, so I would start with this.Before creating a pull request
make format
-DDART_TREAT_WARNINGS_AS_ERRORS=ON
and resolve all the compile warningsBefore merging a pull request
CHANGELOG.md