Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix joint stuck at limit bug #1818

Open
wants to merge 4 commits into
base: release-6.14
Choose a base branch
from

Conversation

ufrhaidar
Copy link

@ufrhaidar ufrhaidar commented Jun 26, 2024

Fix #1683 and gazebosim/gz-sim#1684

result:

2024-06-26_17-53-51.mp4

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.14.1 milestone Jun 26, 2024
@jslee02 jslee02 changed the base branch from main to release-6.14 June 26, 2024 13:45
@jslee02 jslee02 modified the milestones: DART 6.14.1, DART 6.14.2 Jun 26, 2024
@jslee02
Copy link
Member

jslee02 commented Jun 26, 2024

Could you please take a look at the test failures?

@ufrhaidar
Copy link
Author

I don't believe that the changes I've done are the correct thing to do. It just was what got the system out of the velocity limit loop (when position is equal to limit).

Deleting the velocity limit section also fixed the issue, but I don't know what effects it will have on other joint types.

Would this change be acceptable?

@ufrhaidar
Copy link
Author

@jslee02 what needs to be done now?

@jslee02
Copy link
Member

jslee02 commented Jul 21, 2024

Apologies for the delayed response. I am currently on vacation and will be sporadic in my availability to provide a thorough analysis of this issue and the patch for this PR.

Regarding this PR, as you mentioned, I am also uncertain about the potential side effects of disabling the velocity limit correction for servo motor types. I wonder if there is a better way to address the issue without completely disabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joint can't recover from position limits in servo mode
2 participants