Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support swapping left/right panels in darkroom #17467

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

dterrahe
Copy link
Member

@dterrahe dterrahe commented Sep 12, 2024

  • new preference under darkroom/modules

Other changes/refinements:

  • add an event box in the empty space at the bottom of the panels and connect tooltip and drag/drop handler there. Not only does this simplify things, it prevents tooltips shining through in the wrong places, like resizable listviews.
    image
  • To avoid this empty event box from getting destroyed, clean up destruction of iops. It seems that the error conditions that existing in the past that made it "safer" to hide instead of destroy widgets no longer exist. Obviously, needs (more) testing (adding, then removing, then dragging iops (to top and bottom of list etc)
  • further simplify creation of side panels. There was some leftover stuff from when they still could sometimes show horizontal scrollbars. As usual with any cleanup: they can break stuff, so test scroll behavior etc.
  • scroll the currently dragged module or the one above or below it into view, even if the dragged module cannot be dropped there. This helps moving a module that is currently shown at the top upwards or one that is at the bottom downward.
  • got rid of a few GTK-CRITICALS because sometimes gtk can't keep up allocating widgets or starts a d&d without a source.
  • also made sure to clean up drop zones at the end in case drag/leave messages got delivered out of order in a hurry to process a drop.

Maybe fixes #17478

@TurboGit TurboGit added this to the 5.0 milestone Sep 13, 2024
@TurboGit TurboGit added the scope: UI user interface and interactions label Sep 13, 2024
@TurboGit TurboGit self-requested a review September 13, 2024 06:17
@dterrahe dterrahe marked this pull request as draft September 13, 2024 13:59
@dterrahe dterrahe force-pushed the leftrightdragindark branch 2 times, most recently from f6aee33 to 0e56170 Compare September 13, 2024 17:59
@dterrahe dterrahe marked this pull request as ready for review September 13, 2024 18:13
@dterrahe dterrahe marked this pull request as draft September 13, 2024 19:50
@dterrahe dterrahe force-pushed the leftrightdragindark branch 2 times, most recently from 6d674b9 to 527af83 Compare September 13, 2024 22:17
@dterrahe dterrahe marked this pull request as ready for review September 13, 2024 22:22
@dterrahe dterrahe added the bugfix pull request fixing a bug label Sep 16, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple comment for now. Works fine otherwise.

data/darktableconfig.xml.in Outdated Show resolved Hide resolved
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit merged commit d188e26 into darktable-org:master Sep 17, 2024
6 checks passed
@elstoc elstoc added the documentation-pending a documentation work is required label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug documentation-pending a documentation work is required scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arbitrary blank panel positions in module menu after dragging modules
3 participants