Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify importance_hint #15507

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

jenshannoschwalm
Copy link
Collaborator

While changing some module's parameters while not being in_focus (for example by shortcuts) we want this information because

  • we want the input cacheline of the module with high priority because it's likely to be used again pretty soon
  • cl devices want to write clbuffer to the cache too

Instead of keeping that information local in the module we keep track of it in dev, lower memory footprint and more logical.

While changing some module's parameters while not being in_focus (for example by shortcuts)
we want this information because
- we want the input cacheline of the module with high priority because it's likely to be used
  again pretty soon
- cl devices want to write clbuffer to the cache too

Instead of keeping that information local in the module we keep track of it in dev, lower
memory footprint and more logical.
@jenshannoschwalm jenshannoschwalm added the scope: codebase making darktable source code easier to manage label Oct 28, 2023
@jenshannoschwalm jenshannoschwalm added this to the 4.6 milestone Oct 28, 2023
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@TurboGit TurboGit merged commit cab307c into darktable-org:master Oct 29, 2023
5 checks passed
@jenshannoschwalm jenshannoschwalm deleted the cleanup_input_hint branch October 31, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: codebase making darktable source code easier to manage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants