-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hello-kubernetes multi-app run k8s template #926
add hello-kubernetes multi-app run k8s template #926
Conversation
5a85a55
to
716d13e
Compare
interesting that the validation succeeds for multi-app-run k8s but fails for the normal run ... the issue being that python app fails to deploy... will investigate more on Monday. |
tutorials/hello-kubernetes/README.md
Outdated
The first thing you need is an RBAC enabled Kubernetes cluster. This could be running on your machine using Minikube, or it could be a fully-fledged cluster in Azure using [AKS](https://azure.microsoft.com/en-us/services/kubernetes-service/). | ||
|
||
Once you have a cluster, follow the steps below to deploy Dapr to it. For more details, see [Deploy Dapr on a Kubernetes cluster](https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-deploy/). | ||
## Using Dapr Mutli-app run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be more descriptive with this title? This is actually two steps right?
- Installing Dapr runtime and all of the dependencies (redis , zipkin)
- Dapr run using multi-app run file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to Using Dapr Mutli-app run with Dapr `dev` mode deployment
Once you have a cluster, follow the steps below to deploy Dapr to it. For more details, see [Deploy Dapr on a Kubernetes cluster](https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-deploy/). | ||
## Using Dapr Mutli-app run | ||
|
||
### Step 1 - Setup Dapr dev mode on your Kubernetes cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Step 1 - Setup Dapr dev mode on your Kubernetes cluster | |
### Step 1 - Set up Dapr in dev mode on your Kubernetes cluster |
tutorials/hello-kubernetes/README.md
Outdated
The first thing you need is an RBAC enabled Kubernetes cluster. This could be running on your machine using Minikube, or it could be a fully-fledged cluster in Azure using [AKS](https://azure.microsoft.com/en-us/services/kubernetes-service/). | ||
|
||
Once you have a cluster, follow the steps below to deploy Dapr to it. For more details, see [Deploy Dapr on a Kubernetes cluster](https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-deploy/). | ||
## Using Dapr Mutli-app run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add "Using Multi-app run" and "Using the kubectl CLI" into separate tabs to make this the whole tutorial shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain this again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we can do that in GH
|
||
This spins down the Kubernetes resources that were deployed in the previous step. | ||
|
||
## Using the `kubectl` CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a tab here, to make this tutorial shorter. Can then either use Multi-app run or kubectl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding tabs is possible in Hugo which we use for docs, is it possible in normal Github Readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not something we can do in GH
Also see this issue dapr/cli#1351 that need to be looked into |
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
17ded7e
to
a66386e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
closes #914
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: