Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Readme's to default to dapr run -f . #874

Merged
merged 13 commits into from
Sep 22, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jun 6, 2023

Description

Change readme's to favor and default to multi-app-run behavior using dapr run -f .

Carefully tweak test with 15 second sleep and up to 60second timeout for predictable automated testing.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@paulyuk paulyuk added P1 do-not-merge Do not merge the PR labels Jun 6, 2023
@paulyuk paulyuk added this to the 1.11 milestone Jun 6, 2023
@paulyuk paulyuk self-assigned this Jun 6, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not remove the steps to show how to start these individually, just put these after the multi-app run. Showing how to use the dapr run command for a single app is still important IMO (the parameters) and needed until the multi-app run command becomes more adopted. If in time multi-app run shows its value, then we can consider having just that, but too early now IMO.

@paulyuk
Copy link
Contributor Author

paulyuk commented Jun 6, 2023

I would not remove the steps to show how to start these individually, just put these after the multi-app run. Showing how to use the dapr run command for a single app is still important IMO (the parameters) and needed until the multi-app run command becomes more adopted. If in time multi-app run shows its value, then we can consider having just that, but too early now IMO.

Ok sounds like a reasonable compromise. I'm not a super big fan of lots of options which themselves create more conceptual overhead, but given where we are, I agree this is a good way to ease into the new model and ensure it's ready or not to be the main thing we show and do.

@philliphoff
Copy link

I might also note in the READMEs that dapr run -f on Windows requires the upcoming Dapr 1.12.

msfussell
msfussell previously approved these changes Sep 8, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk removed the do-not-merge Do not merge the PR label Sep 22, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@msfussell msfussell merged commit dcd97ee into dapr:master Sep 22, 2023
4 of 7 checks passed
@paulyuk paulyuk deleted the multi-app-run branch September 22, 2023 22:34
msfussell added a commit that referenced this pull request Sep 25, 2023
* Add holopin.yml config (#923)

Signed-off-by: Marc Duiker <[email protected]>

* Updating Readme's to default to `dapr run -f .` (#874)

* Updating Invoke readme in C# to favor dapr run -f

Signed-off-by: Paul Yuknewicz <[email protected]>

* Adding back single app run steps and tests, but to the end.

Signed-off-by: Paul Yuknewicz <[email protected]>

* Update service_invocation/csharp/http/README.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated and hardened test

Signed-off-by: Paul Yuknewicz <[email protected]>

* Invoke * and partial PubSub with multi-run files & readmes & tests

Signed-off-by: Paul Yuknewicz <[email protected]>

* Multi run done for Pubsub C#, Python and Node (http, sdk)

Signed-off-by: Paul Yuknewicz <[email protected]>

* Added Pubsub support for Go, Java

Signed-off-by: Paul Yuknewicz <[email protected]>

* updating readmes with correct appid

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating tests for PubSub and Service invoke to Paas with multiapp run

Signed-off-by: Paul Yuknewicz <[email protected]>

* More fine tuning of pubsub tests (timeouts, step ends)

Signed-off-by: Paul Yuknewicz <[email protected]>

* Fixing Python FastAPI and C# Pubsub tests

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Patching tests to pass (C# timing, Python uvicorn) (#933)

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
msfussell added a commit that referenced this pull request Oct 13, 2023
* update dapr runtime to use v1.12.0-rc.1

Signed-off-by: Cassandra Coyle <[email protected]>

* update to latest rc for runtime and cli

Signed-off-by: Cassandra Coyle <[email protected]>

* try sleeping

Signed-off-by: Cassandra Coyle <[email protected]>

* pin redis version

Signed-off-by: Cassandra Coyle <[email protected]>

* rm sleep

Signed-off-by: Cassandra Coyle <[email protected]>

* rm deprecated unsubscribe call

Signed-off-by: Cassandra Coyle <[email protected]>

* Update configuration/go/sdk/order-processor/app.go

Co-authored-by: Josh van Leeuwen <[email protected]>
Signed-off-by: Cassie Coyle <[email protected]>

* Statemanagement multiapp run

Signed-off-by: rabollin <[email protected]>

* message sequence

Signed-off-by: rabollin <[email protected]>

* message sequence

Signed-off-by: rabollin <[email protected]>

* Multi-run support for workflow

Signed-off-by: Paul Yuknewicz <[email protected]>

* Removing component folder from run file to match readme

Signed-off-by: Paul Yuknewicz <[email protected]>

* aligning state store names on `statestore`

Signed-off-by: Paul Yuknewicz <[email protected]>

* Adding multi-app run for python and C#

Signed-off-by: Paul Yuknewicz <[email protected]>

* pr comments

Signed-off-by: rabollin <[email protected]>

* pr comments

Signed-off-by: rabollin <[email protected]>

* sleep value increase

Signed-off-by: rabollin <[email protected]>

* sleep seconds increase

Signed-off-by: rabollin <[email protected]>

* Result correction

Signed-off-by: rabollin <[email protected]>

* Result correction

Signed-off-by: rabollin <[email protected]>

* java sdk dapr run output format fixing

Signed-off-by: rabollin <[email protected]>

* Syncing Release 1.12 with master and multi-run changes (#936)

* Add holopin.yml config (#923)

Signed-off-by: Marc Duiker <[email protected]>

* Updating Readme's to default to `dapr run -f .` (#874)

* Updating Invoke readme in C# to favor dapr run -f

Signed-off-by: Paul Yuknewicz <[email protected]>

* Adding back single app run steps and tests, but to the end.

Signed-off-by: Paul Yuknewicz <[email protected]>

* Update service_invocation/csharp/http/README.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated and hardened test

Signed-off-by: Paul Yuknewicz <[email protected]>

* Invoke * and partial PubSub with multi-run files & readmes & tests

Signed-off-by: Paul Yuknewicz <[email protected]>

* Multi run done for Pubsub C#, Python and Node (http, sdk)

Signed-off-by: Paul Yuknewicz <[email protected]>

* Added Pubsub support for Go, Java

Signed-off-by: Paul Yuknewicz <[email protected]>

* updating readmes with correct appid

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating tests for PubSub and Service invoke to Paas with multiapp run

Signed-off-by: Paul Yuknewicz <[email protected]>

* More fine tuning of pubsub tests (timeouts, step ends)

Signed-off-by: Paul Yuknewicz <[email protected]>

* Fixing Python FastAPI and C# Pubsub tests

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Patching tests to pass (C# timing, Python uvicorn) (#933)

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Fixing MMD tests with tweaks

Signed-off-by: Paul Yuknewicz <[email protected]>

* setting version for kafka (#939)

* fixing version for kafka

Signed-off-by: Pravin Pushkar <[email protected]>

* validate data with some initial values instead of larger

Signed-off-by: Pravin Pushkar <[email protected]>

---------

Signed-off-by: Pravin Pushkar <[email protected]>

* Updating test env to Dapr runtime 1.12 RC4 and CLI RC2

Signed-off-by: Paul Yuknewicz <[email protected]>

* Update README.md

Fixing typo.  should be singular

Signed-off-by: Paul Yuknewicz <[email protected]>

* Update README.md

Signed-off-by: Paul Yuknewicz <[email protected]>

* add java workflow quickstart

Signed-off-by: Sky Ao <[email protected]>

* Updating runtime for tests to RC5

Signed-off-by: Paul Yuknewicz <[email protected]>

* Fixes port 6003 conflict between Go Pub-sub and Go bindings.  Timing issue

Signed-off-by: Paul Yuknewicz <[email protected]>

* add hello-kubernetes multi-app run k8s template

Signed-off-by: Mukundan Sundararajan <[email protected]>

* address review comments.

Signed-off-by: Mukundan Sundararajan <[email protected]>

* update cli to rc.4 (#943)

* update cli to rc.3

Signed-off-by: Cassandra Coyle <[email protected]>

* update cli to rc.4

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassie Coyle <[email protected]>

* Update CLI to rc4

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating .NET SDK to 1.12.*

Signed-off-by: Paul Yuknewicz <[email protected]>

* Dapr Golang SDK update to v1.9.0-rc-1

Signed-off-by: Paul Yuknewicz <[email protected]>

* Javascript SDK to 3.1.2

Signed-off-by: Paul Yuknewicz <[email protected]>

* Release 1.12 (#945)

* Dapr Golang SDK update to v1.9.0-rc-1

Signed-off-by: Paul Yuknewicz <[email protected]>

* Javascript SDK to 3.1.2

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>

* Java SDK update to <version>1.10.0-rc-1</version>

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated Java SDK to RC, and donated multi-app-run support too :)

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating tests to use dapr/dapr 1.12.0-rc.6

Signed-off-by: Paul Yuknewicz <[email protected]>

* sdk version changes

Signed-off-by: rabollin <[email protected]>

* CLI and Runtime version changes

Signed-off-by: rabollin <[email protected]>

* go.sum refresh

Signed-off-by: rabollin <[email protected]>

* Updating with js-sdk 3.2.0

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassie Coyle <[email protected]>
Signed-off-by: rabollin <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Cassandra Coyle <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]>
Co-authored-by: rabollin <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Co-authored-by: Pravin Pushkar <[email protected]>
Co-authored-by: Sky Ao <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants