Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job sdk / go validation #1077

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jul 26, 2024

Description

  • Re-enable the go jobs SDK example
  • Modifes the multi app run template
    • Specifies a log destination (console)
  • Modifies mechanical markdown for go validation examples to account for multi-app run issues:
    • jobs
    • pubsub
    • service invocation
    • state management
    • workflows
  • Override daprd with the programmatic subscriptions fix

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1071, #1026

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. this is always timing dependent in real runners, so let's just check the Check/tests results.

jobs/go/sdk/dapr.yaml Outdated Show resolved Hide resolved
@mikeee mikeee mentioned this pull request Jul 26, 2024
4 tasks
Signed-off-by: mikeee <[email protected]>
@paulyuk paulyuk added bug Something isn't working P1 area/jobs labels Jul 26, 2024
@paulyuk paulyuk added this to the 1.14 milestone Jul 26, 2024
@mikeee mikeee marked this pull request as ready for review July 26, 2024 22:13
@mikeee mikeee changed the title fix: job sdk validation fix: job sdk / go validation Jul 27, 2024
@paulyuk paulyuk merged commit f1ce393 into dapr:release-1.14 Jul 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs bug Something isn't working P1
Projects
Development

Successfully merging this pull request may close these issues.

2 participants